Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2501083002: [Android DomKey] Add TV, Navigate, Media and others missing mappings (Closed)

Created:
4 years, 1 month ago by chongz
Modified:
4 years, 1 month ago
Reviewers:
garykac
CC:
chromium-reviews, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android DomKey] Add TV, Navigate, Media and others missing mappings This CL added/fixed 51 missing mappings according to UI Events spec, most of which are new / not supported before. Please refer to bug description for the full list of mappings. spec: https://w3c.github.io/uievents-key/ TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 275", etc 4. Verify produced "key" BUG=662011 Committed: https://crrev.com/69074537e7bd722e27bc2734d00d178bfea27f46 Cr-Commit-Position: refs/heads/master@{#432797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -43 lines) Patch
M ui/events/keycodes/dom/dom_key_data.inc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_android.cc View 10 chunks +107 lines, -42 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
chongz
garykac@ PTAL, thanks!
4 years, 1 month ago (2016-11-14 20:46:29 UTC) #7
garykac
lgtm Thanks!
4 years, 1 month ago (2016-11-16 23:47:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501083002/1
4 years, 1 month ago (2016-11-17 00:27:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/316581)
4 years, 1 month ago (2016-11-17 02:20:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501083002/1
4 years, 1 month ago (2016-11-17 06:48:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 07:15:42 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 07:17:57 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69074537e7bd722e27bc2734d00d178bfea27f46
Cr-Commit-Position: refs/heads/master@{#432797}

Powered by Google App Engine
This is Rietveld 408576698