Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2501063003: Handle compositor/worker context the same wrt. visibility (Closed)

Created:
4 years, 1 month ago by ericrk
Modified:
4 years, 1 month ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle compositor/worker context the same wrt. visibility When transitioning the worker context to not-visible mode and cleaning up resources, we wait for pending tile tasks to complete, as they may be using resources. Given that the resources used by tile tasks are created/destroyed on the compositor context (not the worker context), we should also delay compositor context's cleanup until all tile tasks are completed. This change modifies LayerTreeHostImpl so that both contexts have their visibility handled in the same way. Additionally, it fixes an issue where we were checking resource pool for pending cleanup in the wrong way (looking only at in-use resources, not at all resources). R=enne BUG=663179 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/174ef9083488b3d8528e9fa60820d0cec3badd50 Cr-Commit-Position: refs/heads/master@{#432282}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -65 lines) Patch
M cc/resources/resource_pool.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 6 chunks +32 lines, -56 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ericrk
4 years, 1 month ago (2016-11-15 17:35:24 UTC) #2
enne (OOO)
lgtm
4 years, 1 month ago (2016-11-15 19:10:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501063003/20001
4 years, 1 month ago (2016-11-15 22:54:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 23:11:20 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 23:14:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/174ef9083488b3d8528e9fa60820d0cec3badd50
Cr-Commit-Position: refs/heads/master@{#432282}

Powered by Google App Engine
This is Rietveld 408576698