Properly release caches in CPDF_DocRenderData

Properly release caches in CPDF_DocRenderData

Currently, only RemoveRef() is being called when releasing. The problem
is that when the object is no longer being used, the map is not updated
accordingly. In the pdf in the bug below, the pointer of a font used in
the second page coincides with the pointer of a font in the first page
(that was released). So the cached values for the font in the first
page are used, resulting in incorrect rendering.

BUG=pdfium:629
Committed: https://pdfium.googlesource.com/pdfium/+/be83b31dc4f21e7be066ac1093fcd9b6aab058ed

[npm, 2016-11-14 18:20:19]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:20:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-14 18:20:36]

Description was changed from

==========
Properly release caches in CPDF_DocRenderData

Currently, only RemoveRef() is being called when releasing. The problem
is that when the object is no longer being used, the map is not updated
accordingly. In the pdf in the bug below, the pointer of a font used in
the second page coincides with the pointer of a font in the first page
(that was released). So the cached values for the font in the first
page are used, resulting in incorrect rendering.

BUG=pdfium:629
==========

to

==========
Properly release caches in CPDF_DocRenderData

Currently, only RemoveRef() is being called when releasing. The problem
is that when the object is no longer being used, the map is not updated
accordingly. In the pdf in the bug below, the pointer of a font used in
the second page coincides with the pointer of a font in the first page
(that was released). So the cached values for the font in the first
page are used, resulting in incorrect rendering.

BUG=pdfium:629
==========

[npm, 2016-11-14 18:20:36]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, tsepez@chromium.org

[npm, 2016-11-14 18:21:14]

PTAL

[commit-bot: I haz the power, 2016-11-14 18:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 18:35:27]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-14 19:39:28]

lgtm

[Tom Sepez, 2016-11-14 19:39:29]

lgtm

lgtm

[npm, 2016-11-14 20:15:38]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-14 20:15:51]

On 2016/11/14 19:39:29, Tom Sepez wrote:
> lgtm
> 
> lgtm

Triple lgtm? Thanks! :P

[commit-bot: I haz the power, 2016-11-14 20:16:06]

Description was changed from

==========
Properly release caches in CPDF_DocRenderData

Currently, only RemoveRef() is being called when releasing. The problem
is that when the object is no longer being used, the map is not updated
accordingly. In the pdf in the bug below, the pointer of a font used in
the second page coincides with the pointer of a font in the first page
(that was released). So the cached values for the font in the first
page are used, resulting in incorrect rendering.

BUG=pdfium:629
==========

to

==========
Properly release caches in CPDF_DocRenderData

Currently, only RemoveRef() is being called when releasing. The problem
is that when the object is no longer being used, the map is not updated
accordingly. In the pdf in the bug below, the pointer of a font used in
the second page coincides with the pointer of a font in the first page
(that was released). So the cached values for the font in the first
page are used, resulting in incorrect rendering.

BUG=pdfium:629

Committed:
https://pdfium.googlesource.com/pdfium/+/be83b31dc4f21e7be066ac1093fcd9b6aab0...
==========

[commit-bot: I haz the power, 2016-11-14 20:16:07]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/be83b31dc4f21e7be066ac1093fcd9b6aab0...