Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250103002: Adding GetEventSource() method to the WindowTreeHost class. (Closed)

Created:
6 years, 8 months ago by mfomitchev
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tdanderson+views_chromium.org, ben+aura_chromium.org, viettrungluu+watch_chromium.org, tfarina, abarth-chromium, Aaron Boodman, kalyank, sadrul, darin (slow to review), ben+mojo_chromium.org, ben+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding GetEventSource() method to the WindowTreeHost class. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266024

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M mojo/examples/aura_demo/window_tree_host_mojo.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/aura_demo/window_tree_host_mojo.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_tree_host_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_ozone.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mfomitchev
@sadrul - can you please take the first look? Thanks!
6 years, 8 months ago (2014-04-23 19:43:13 UTC) #1
sadrul
Thanks! LGTM +ben@ https://codereview.chromium.org/250103002/diff/1/ui/aura/window_tree_host.h File ui/aura/window_tree_host.h (right): https://codereview.chromium.org/250103002/diff/1/ui/aura/window_tree_host.h#newcode115 ui/aura/window_tree_host.h:115: virtual ui::EventSource* GetEventSource() = 0; + ...
6 years, 8 months ago (2014-04-23 19:48:40 UTC) #2
mfomitchev
https://codereview.chromium.org/250103002/diff/1/ui/aura/window_tree_host.h File ui/aura/window_tree_host.h (right): https://codereview.chromium.org/250103002/diff/1/ui/aura/window_tree_host.h#newcode115 ui/aura/window_tree_host.h:115: virtual ui::EventSource* GetEventSource() = 0; On 2014/04/23 19:48:40, sadrul ...
6 years, 8 months ago (2014-04-23 20:05:40 UTC) #3
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-24 15:49:56 UTC) #4
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 8 months ago (2014-04-24 15:50:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/250103002/20001
6 years, 8 months ago (2014-04-24 15:51:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 17:00:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 17:00:41 UTC) #8
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 8 months ago (2014-04-24 17:03:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/250103002/20001
6 years, 8 months ago (2014-04-24 17:04:36 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:04:05 UTC) #11
Message was sent while issue was closed. 
Change committed as 266024

Powered by Google App Engine
This is Rietveld 408576698