Converts test_wm to use aura

services/ui/test_wm/test_wm.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <utility>
 
+#include "base/bind.h"
+#include "base/memory/ptr_util.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "services/service_manager/public/c/main.h"
 #include "services/service_manager/public/cpp/connector.h"
 #include "services/service_manager/public/cpp/service.h"
 #include "services/service_manager/public/cpp/service_context.h"
 #include "services/service_manager/public/cpp/service_runner.h"
-#include "services/ui/public/cpp/window.h"
-#include "services/ui/public/cpp/window_manager_delegate.h"
-#include "services/ui/public/cpp/window_tree_client.h"
-#include "services/ui/public/cpp/window_tree_client_delegate.h"
+#include "ui/aura/env.h"
+#include "ui/aura/mus/gpu_service.h"
+#include "ui/aura/mus/mus_context_factory.h"
+#include "ui/aura/mus/property_converter.h"
+#include "ui/aura/mus/window_manager_delegate.h"
+#include "ui/aura/mus/window_tree_client.h"
+#include "ui/aura/mus/window_tree_client_delegate.h"
+#include "ui/aura/mus/window_tree_host_mus.h"
+#include "ui/aura/test/test_focus_client.h"
+#include "ui/aura/window.h"
+#include "ui/compositor/test/context_factories_for_test.h"
 #include "ui/display/display.h"
+#include "ui/gl/test/gl_surface_test_support.h"
+#include "ui/wm/core/capture_controller.h"
+#include "ui/wm/core/wm_state.h"
 
 namespace ui {
 namespace test {
 
 class TestWM : public service_manager::Service,
-               public ui::WindowTreeClientDelegate,
-               public ui::WindowManagerDelegate {
+               public aura::WindowTreeClientDelegate,
+               public aura::WindowManagerDelegate {
  public:
-  TestWM() {}
-  ~TestWM() override {}
+  TestWM() { gl::GLSurfaceTestSupport::InitializeOneOff(); }

[sadrul, 2016/11/18 01:03:53]

Do you need to initialize gl here?

[sky, 2016/11/18 05:11:06]

I'm not sure. Should I be? I did update the patch so that
--override-use-gl-with-osmesa-for-tests is added as an arg to
views_mus_unittests and views_mus_interactive_ui_tests. Take another look?

[Fady Samuel, 2016/11/23 00:39:53]

I wonder if this is happening too late? This usually seems to get called very
early in the TestSuite:

https://cs.chromium.org/chromium/src/ash/test/test_suite.cc?sq=package:chromi...

+  ~TestWM() override {
+    // WindowTreeHost uses state from WindowTreeClient, so destroy it first.
+    window_tree_host_.reset();
+
+    // WindowTreeClient destruction may callback to us.
+    window_tree_client_.reset();
+
+    gpu_service_.reset();
+  }
 
  private:
   // service_manager::Service:
   void OnStart() override {
-    window_tree_client_.reset(new ui::WindowTreeClient(this, this));
+    aura_env_ = aura::Env::CreateInstance(aura::Env::Mode::MUS);
+    gpu_service_ = aura::GpuService::Create(context()->connector(), nullptr);
+    compositor_context_factory_ =
+        base::MakeUnique<aura::MusContextFactory>(gpu_service_.get());
+    aura_env_->set_context_factory(compositor_context_factory_.get());
+    window_tree_client_ = base::MakeUnique<aura::WindowTreeClient>(this, this);
+    aura_env_->SetWindowTreeClient(window_tree_client_.get());
     window_tree_client_->ConnectAsWindowManager(context()->connector());
   }
 
   bool OnConnect(const service_manager::ServiceInfo& remote_info,
                  service_manager::InterfaceRegistry* registry) override {
     return false;
   }
 
-  // ui::WindowTreeClientDelegate:
-  void OnEmbed(ui::Window* root) override {
+  // aura::WindowTreeClientDelegate:
+  void OnEmbed(
+      std::unique_ptr<aura::WindowTreeHostMus> window_tree_host) override {
     // WindowTreeClients configured as the window manager should never get
     // OnEmbed().
     NOTREACHED();
   }
-  void OnLostConnection(WindowTreeClient* client) override {
+  void OnLostConnection(aura::WindowTreeClient* client) override {
+    window_tree_host_.reset();
     window_tree_client_.reset();
   }
-  void OnEmbedRootDestroyed(ui::Window* root) override {
+  void OnEmbedRootDestroyed(aura::Window* root) override {
     // WindowTreeClients configured as the window manager should never get
     // OnEmbedRootDestroyed().
     NOTREACHED();
   }
   void OnPointerEventObserved(const ui::PointerEvent& event,
-                              ui::Window* target) override {
+                              aura::Window* target) override {
     // Don't care.
   }
+  aura::client::CaptureClient* GetCaptureClient() override {
+    return wm_state_.capture_controller();
+  }
+  aura::PropertyConverter* GetPropertyConverter() override {
+    return &property_converter_;
+  }
 
-  // ui::WindowManagerDelegate:
-  void SetWindowManagerClient(ui::WindowManagerClient* client) override {
+  // aura::WindowManagerDelegate:
+  void SetWindowManagerClient(aura::WindowManagerClient* client) override {
     window_manager_client_ = client;
   }
-  bool OnWmSetBounds(ui::Window* window, gfx::Rect* bounds) override {
+  bool OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) override {
     return true;
   }
   bool OnWmSetProperty(
-      ui::Window* window,
+      aura::Window* window,
       const std::string& name,
       std::unique_ptr<std::vector<uint8_t>>* new_data) override {
     return true;
   }
-  ui::Window* OnWmCreateTopLevelWindow(
+  aura::Window* OnWmCreateTopLevelWindow(
       std::map<std::string, std::vector<uint8_t>>* properties) override {
-    ui::Window* window = root_->window_tree()->NewWindow(properties);
+    aura::Window* window = new aura::Window(nullptr);
+    window->Init(LAYER_NOT_DRAWN);
     window->SetBounds(gfx::Rect(10, 10, 500, 500));
     root_->AddChild(window);
     return window;
   }
-  void OnWmClientJankinessChanged(const std::set<Window*>& client_windows,
+  void OnWmClientJankinessChanged(const std::set<aura::Window*>& client_windows,
                                   bool janky) override {
     // Don't care.
   }
-  void OnWmNewDisplay(Window* window,
+  void OnWmNewDisplay(std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
                       const display::Display& display) override {
     // Only handles a single root.
     DCHECK(!root_);
-    root_ = window;
+    window_tree_host_ = std::move(window_tree_host);
+    root_ = window_tree_host_->window();
     DCHECK(window_manager_client_);
     window_manager_client_->AddActivationParent(root_);
     ui::mojom::FrameDecorationValuesPtr frame_decoration_values =
         ui::mojom::FrameDecorationValues::New();
     frame_decoration_values->max_title_bar_button_width = 0;
     window_manager_client_->SetFrameDecorationValues(
         std::move(frame_decoration_values));
+    aura::client::SetFocusClient(root_, &focus_client_);
   }
-  void OnWmDisplayRemoved(ui::Window* window) override { window->Destroy(); }
+  void OnWmDisplayRemoved(aura::WindowTreeHostMus* window_tree_host) override {
+    DCHECK_EQ(window_tree_host, window_tree_host_.get());
+    window_tree_host_.reset();
+  }
   void OnWmDisplayModified(const display::Display& display) override {}
-  void OnWmPerformMoveLoop(Window* window,
+  void OnWmPerformMoveLoop(aura::Window* window,
                            mojom::MoveLoopSource source,
                            const gfx::Point& cursor_location,
                            const base::Callback<void(bool)>& on_done) override {
     // Don't care.
   }
-  void OnWmCancelMoveLoop(Window* window) override {}
+  void OnWmCancelMoveLoop(aura::Window* window) override {}
 
-  ui::Window* root_ = nullptr;
-  ui::WindowManagerClient* window_manager_client_ = nullptr;
-  std::unique_ptr<ui::WindowTreeClient> window_tree_client_;
+  std::unique_ptr<aura::Env> aura_env_;
+  ::wm::WMState wm_state_;
+  aura::PropertyConverter property_converter_;
+  aura::test::TestFocusClient focus_client_;
+  std::unique_ptr<aura::WindowTreeHostMus> window_tree_host_;
+  aura::Window* root_ = nullptr;
+  aura::WindowManagerClient* window_manager_client_ = nullptr;
+  std::unique_ptr<aura::WindowTreeClient> window_tree_client_;
+  std::unique_ptr<aura::GpuService> gpu_service_;
+  std::unique_ptr<aura::MusContextFactory> compositor_context_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TestWM);
 };
 
 }  // namespace test
 }  // namespace ui
 
 MojoResult ServiceMain(MojoHandle service_request_handle) {
   service_manager::ServiceRunner runner(new ui::test::TestWM);
   return runner.Run(service_request_handle);
 }