Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2500963006:
Replace fcvt with std::stringstream in AFNumber_Format (Closed)
DescriptionReplace fcvt with std::stringstream in AFNumber_Format
On Mac, fcvt is returning an empty string when ndigit is 0. This causes
the field to be replaced with "0" when applying AFNumber_Format.
BUG=chromium:113910
Committed: https://pdfium.googlesource.com/pdfium/+/49c5928f4725c679c52b34400610d898a799ffd9
Patch Set 1 #Patch Set 2 : Not you, Android #
Total comments: 4
Patch Set 3 : Nits #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by npm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)
Description was changed from ========== Replace fcvt with std::stringstream in AFNumber_Format On Mac, fcvt is returning an empty string when ndigit is 0. This causes the field to be replaced with "0" when applying AFNumber_Format. BUG=chromium:113910 ========== to ========== Replace fcvt with std::stringstream in AFNumber_Format On Mac, fcvt is returning an empty string when ndigit is 0. This causes the field to be replaced with "0" when applying AFNumber_Format. BUG=chromium:113910 ==========
npm@chromium.org changed reviewers: + dsinclair@chromium.org, thestig@chromium.org, tsepez@chromium.org
The CQ bit was checked by npm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2500963006/diff/20001/fpdfsdk/javascript/Publ... File fpdfsdk/javascript/PublicMethods.cpp (right): https://codereview.chromium.org/2500963006/diff/20001/fpdfsdk/javascript/Publ... fpdfsdk/javascript/PublicMethods.cpp:94: int* iNegative) { nit: maybe iNegative should be a bool*. https://codereview.chromium.org/2500963006/diff/20001/fpdfsdk/javascript/Publ... fpdfsdk/javascript/PublicMethods.cpp:95: *iNegative = dValue < 0 ? 1 : 0; then its just *iNegative = dvalue < 0; if bool used above.
https://codereview.chromium.org/2500963006/diff/20001/fpdfsdk/javascript/Publ... File fpdfsdk/javascript/PublicMethods.cpp (right): https://codereview.chromium.org/2500963006/diff/20001/fpdfsdk/javascript/Publ... fpdfsdk/javascript/PublicMethods.cpp:94: int* iNegative) { On 2016/11/15 22:37:30, Tom Sepez wrote: > nit: maybe iNegative should be a bool*. Done. https://codereview.chromium.org/2500963006/diff/20001/fpdfsdk/javascript/Publ... fpdfsdk/javascript/PublicMethods.cpp:95: *iNegative = dValue < 0 ? 1 : 0; On 2016/11/15 22:37:30, Tom Sepez wrote: > then its just *iNegative = dvalue < 0; if bool used above. Done.
The CQ bit was checked by npm@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org Link to the patchset: https://codereview.chromium.org/2500963006/#ps40001 (title: "Nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Replace fcvt with std::stringstream in AFNumber_Format On Mac, fcvt is returning an empty string when ndigit is 0. This causes the field to be replaced with "0" when applying AFNumber_Format. BUG=chromium:113910 ========== to ========== Replace fcvt with std::stringstream in AFNumber_Format On Mac, fcvt is returning an empty string when ndigit is 0. This causes the field to be replaced with "0" when applying AFNumber_Format. BUG=chromium:113910 Committed: https://pdfium.googlesource.com/pdfium/+/49c5928f4725c679c52b34400610d898a799... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://pdfium.googlesource.com/pdfium/+/49c5928f4725c679c52b34400610d898a799... |
