Issue 2500963002: [ObjC ARC] Converts ios/chrome/browser/autocomplete to ARC.

Issue 2500963002: [ObjC ARC] Converts ios/chrome/browser/autocomplete to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin

Modified:
4 years ago

Reviewers:
noyau (Ping after 24h)

CC:
chromium-reviews, James Su, mac-reviews_chromium.org, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[ObjC ARC] Converts ios/chrome/browser/autocomplete to ARC. Notable changes: none. BUG=663723 Committed: https://crrev.com/8f6d7eb817491e26c9f4ba6639d55bbaca749164 Cr-Commit-Position: refs/heads/master@{#433522}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	ios/chrome/browser/autocomplete/BUILD.gn	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ios/chrome/browser/autocomplete/autocomplete_scheme_classifier_impl.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ios/chrome/browser/autocomplete/shortcuts_backend_factory.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 10 (4 generated)

noyau (Ping after 24h)

Any reason why those files are .mm instead of simply .cc?

4 years, 1 month ago (2016-11-15 08:46:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500963002/1

4 years ago (2016-11-21 12:22:21 UTC) #6

commit-bot: I haz the power

4 years ago (2016-11-21 13:37:36 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8f6d7eb817491e26c9f4ba6639d55bbaca749164
Cr-Commit-Position: refs/heads/master@{#433522}