Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2500953002: [ObjC ARC] Converts ios/chrome/app/application_delegate to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app/application_delegate to ARC. Notable changes: none BUG=659150 Committed: https://crrev.com/96c43169eb84d09f2fe89cb628591b8008d4d543 Cr-Commit-Position: refs/heads/master@{#432184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/chrome/app/application_delegate/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/app/application_delegate/memory_warning_helper.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stkhapugin
ptal
4 years, 1 month ago (2016-11-14 16:23:06 UTC) #2
marq (ping after 24h)
lgtm
4 years, 1 month ago (2016-11-14 16:47:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500953002/1
4 years, 1 month ago (2016-11-15 13:14:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 15:41:03 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 15:42:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96c43169eb84d09f2fe89cb628591b8008d4d543
Cr-Commit-Position: refs/heads/master@{#432184}

Powered by Google App Engine
This is Rietveld 408576698