Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2500933002: [ios] Adds an Initialize() method to OmahaServiceProvider. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds an Initialize() method to OmahaServiceProvider. BUG=663349 Committed: https://crrev.com/bf7f53d032e6a01fcdb94382a6de87961a4f64ea Cr-Commit-Position: refs/heads/master@{#432686}

Patch Set 1 #

Patch Set 2 : Updates. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M ios/public/provider/chrome/browser/omaha/omaha_service_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/omaha/omaha_service_provider.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/omaha/test_omaha_service_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/omaha/test_omaha_service_provider.mm View 1 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-11-14 17:22:59 UTC) #6
sdefresne
lgtm
4 years, 1 month ago (2016-11-14 17:25:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500933002/40001
4 years, 1 month ago (2016-11-16 23:55:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 01:44:00 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 01:48:29 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf7f53d032e6a01fcdb94382a6de87961a4f64ea
Cr-Commit-Position: refs/heads/master@{#432686}

Powered by Google App Engine
This is Rietveld 408576698