No forced active stylesheet recollect when pending sheets reach 0.

No forced active stylesheet recollect when pending sheets reach 0.

We forced a FullStyleUpdate which causes an active stylesheet update
for all tree scopes in the presence of placeholder style. What we need
to do for placeholder style is to trigger a full style recalc. For
instance, we don't need to update active stylesheets in shadow trees
if the last blocking resource that finishes loading is a document scope
stylesheet or import.

BUG=567021
Committed: https://crrev.com/33002601a6ab8429f122c105b3d0179730a3384f
Cr-Commit-Position: refs/heads/master@{#432630}

[rune, 2016-11-14 14:57:24]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 14:57:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 16:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:31:11]

Dry run: This issue passed the CQ dry run.

[rune, 2016-11-15 10:39:02]

rune@opera.com changed reviewers:
+ meade@chromium.org

[rune, 2016-11-15 10:39:03]

ptal

I have not been able to come up with a way to test this other than using unit
tests to test that implementation details like the fact that ScopedStyleResolver
pointers do not change when we don't recollect active stylesheets for shadow
treescopes.

https://codereview.chromium.org/2500923002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (left):

https://codereview.chromium.org/2500923002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:3679: void
Document::styleResolverMayHaveChanged() {
This is a confusing name for this method, but I haven't found a good name for it
yet. It means something along the lines of:

invalidateStyleUpdateActiveStyleSheetsAndMakeSureSuppressedPaintInvalidationsTriggerAfter(Script/Render)BlockingResourcesFinishedLoading();

[meade_UTC10, 2016-11-16 18:10:31]

lgtm

https://codereview.chromium.org/2500923002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (left):

https://codereview.chromium.org/2500923002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:3679: void
Document::styleResolverMayHaveChanged() {
On 2016/11/15 10:39:03, rune wrote:
> This is a confusing name for this method, but I haven't found a good name for
it
> yet. It means something along the lines of:
> 
>
invalidateStyleUpdateActiveStyleSheetsAndMakeSureSuppressedPaintInvalidationsTriggerAfter(Script/Render)BlockingResourcesFinishedLoading();

D:

[rune, 2016-11-16 18:28:31]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-16 18:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 21:24:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 21:39:33]

Description was changed from

==========
No forced active stylesheet recollect when pending sheets reach 0.

We forced a FullStyleUpdate which causes an active stylesheet update
for all tree scopes in the presence of placeholder style. What we need
to do for placeholder style is to trigger a full style recalc. For
instance, we don't need to update active stylesheets in shadow trees
if the last blocking resource that finishes loading is a document scope
stylesheet or import.

BUG=567021
==========

to

==========
No forced active stylesheet recollect when pending sheets reach 0.

We forced a FullStyleUpdate which causes an active stylesheet update
for all tree scopes in the presence of placeholder style. What we need
to do for placeholder style is to trigger a full style recalc. For
instance, we don't need to update active stylesheets in shadow trees
if the last blocking resource that finishes loading is a document scope
stylesheet or import.

BUG=567021

Committed: https://crrev.com/33002601a6ab8429f122c105b3d0179730a3384f
Cr-Commit-Position: refs/heads/master@{#432630}
==========

[commit-bot: I haz the power, 2016-11-16 21:39:34]

Patchset 1 (id:??) landed as
https://crrev.com/33002601a6ab8429f122c105b3d0179730a3384f
Cr-Commit-Position: refs/heads/master@{#432630}