Issue 25009003: Inline some more compare operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25009003: Inline some more compare operations. (Closed)

Created:
7 years, 2 months ago by oliv

Modified:
7 years, 2 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline some more compare operations. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17091

Patch Set 2 : add tests #

Total comments: 3

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -23 lines)			Patch
M	src/hydrogen.cc	View		1 chunk	+29 lines, -0 lines	2 comments	Download
A +	test/mjsunit/compare-known-objects.js	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download
A +	test/mjsunit/compare-objects-fast.js	View	1	2 chunks	+54 lines, -14 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, minor nits. https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc#newcode8304 src/hydrogen.cc:8304: } else if (combined_type->NumClasses() == 1 ...

7 years, 2 months ago (2013-10-02 13:33:19 UTC) #2

oliv

7 years, 2 months ago (2013-10-02 18:16:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17091 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25009003: Inline some more compare operations. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : add tests #

Messages