Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2500873004: Make typing in the filter box handle typing filters (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel, mithro
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make typing in the filter box handle typing filters No longer will typing "pool:Foo" cause all the boxes to be blank, it will be matched and bolded, as one would expect. BUG=664831 Committed: https://github.com/luci/luci-py/commit/f793588b89615c45291eed00711eda672343aab4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/build/js/js.js View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html View 8 chunks +40 lines, -4 lines 0 comments Download
M appengine/swarming/ui/res/js/alias.js View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
kjlubick
Live at https://2483-7beb2a2-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/tasklist?c=name&c=state&c=created_ts&c=user&l=50&q=pool%3ASkia&s=created_ts%3Adesc Demo: https://screencast.googleplex.com/cast/NTQyNDUwMTc1MTgwODAwMHxiZWIwNDZhYS1lOQ
4 years, 1 month ago (2016-11-15 19:29:19 UTC) #3
stephana
On 2016/11/15 19:29:19, kjlubick wrote: > Live at > https://2483-7beb2a2-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/tasklist?c=name&c=state&c=created_ts&c=user&l=50&q=pool%3ASkia&s=created_ts%3Adesc > > Demo: > https://screencast.googleplex.com/cast/NTQyNDUwMTc1MTgwODAwMHxiZWIwNDZhYS1lOQ ...
4 years, 1 month ago (2016-11-15 19:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500873004/1
4 years, 1 month ago (2016-11-16 13:15:03 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-16 13:15:06 UTC) #8
KevinL
lgtm
4 years, 1 month ago (2016-11-16 13:15:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500873004/1
4 years, 1 month ago (2016-11-16 13:15:33 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 13:18:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/f793588b89615c45291eed00711eda672343aab4

Powered by Google App Engine
This is Rietveld 408576698