Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2500833002: Import latest WritableStream tests from upstream (Closed)

Created:
4 years, 1 month ago by Adam Rice
Modified:
4 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import latest WritableStream tests from upstream This imports the latest tests from https://github.com/whatwg/streams/tree/master/reference-implementation/to-upstream-wpts/writable-streams as of commit a3c394a8131e6ef7f86f80521f1f3fd2790b6071 (Nov 11 2016). The updated tests provide a considerable improvement in test coverage. Minor modifications have been made for compatibility with the layout test environment. These tests are in this location temporarily until they have been upstreamed to the w3c web-platform-tests repository. BUG=658144 Committed: https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d Cr-Commit-Position: refs/heads/master@{#432406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/streams/resources/test-utils.js View 3 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.js View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.js View 1 chunk +93 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.https.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.js View 4 chunks +110 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.js View 1 chunk +79 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.js View 1 chunk +33 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.https.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.js View 1 chunk +129 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.https.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.js View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500833002/1
4 years, 1 month ago (2016-11-14 08:21:39 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-14 08:21:40 UTC) #4
Adam Rice
4 years, 1 month ago (2016-11-15 05:47:54 UTC) #6
yhirano
Let me confirm: are you planning to import WritableStream tests automatically in the future?
4 years, 1 month ago (2016-11-15 08:41:07 UTC) #7
Adam Rice
On 2016/11/15 08:41:07, yhirano wrote: > Let me confirm: are you planning to import WritableStream ...
4 years, 1 month ago (2016-11-15 08:52:32 UTC) #9
yhirano
lgtm
4 years, 1 month ago (2016-11-16 02:17:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500833002/1
4 years, 1 month ago (2016-11-16 02:34:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/338237)
4 years, 1 month ago (2016-11-16 03:03:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500833002/1
4 years, 1 month ago (2016-11-16 04:57:05 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 06:43:34 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:48:45 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d
Cr-Commit-Position: refs/heads/master@{#432406}

Powered by Google App Engine
This is Rietveld 408576698