Flush out initial [un]registerServiceWorker roundtrip

content/child/service_worker/service_worker_dispatcher.h

+// Copyright 2013 The Chromium Authors. All rights reserved.

[jam, 2013/10/28 17:05:50]

why are all these new files in content/child instead of content/renderer? stuff
is in content/child because it's used by content/renderer and content/utility,
but in this case i thought this code is only going to be called from the
renderer?

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_H_
+#define CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_H_
+
+#include "base/id_map.h"
+#include "base/memory/ref_counted.h"
+#include "base/strings/string16.h"
+#include "third_party/WebKit/public/platform/WebServiceWorkerProvider.h"
+#include "webkit/child/worker_task_runner.h"
+
+class GURL;
+
+namespace WebKit {
+class WebURL;
+}
+
+namespace IPC {
+class Message;
+}
+
+namespace content {
+class ThreadSafeSender;
+class ServiceWorkerMessageFilter;

[jam, 2013/10/28 17:26:55]

nit: order

[alecflett, 2013/10/28 21:11:43]

Done.

+class WebServiceWorkerImpl;
+
+class ServiceWorkerDispatcher : public webkit_glue::WorkerTaskRunner::Observer {

[jam, 2013/10/28 17:26:55]

nit: please add a small comment to each new class describing its purpose. also
in other files

+ public:
+  explicit ServiceWorkerDispatcher(ThreadSafeSender* thread_safe_sender);
+  virtual ~ServiceWorkerDispatcher();
+
+  void OnMessageReceived(const IPC::Message& msg);
+  bool Send(IPC::Message* msg);
+
+  void RegisterServiceWorker(

[jam, 2013/10/28 17:26:55]

nit: document methods as well

[alecflett, 2013/10/28 21:11:43]

Done.

+      const GURL& pattern,
+      const GURL& script_url,
+      WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks* callbacks);
+  void UnregisterServiceWorker(
+      const GURL& pattern,
+      WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks* callbacks);
+
+  // |thread_safe_sender| needs to be passed in because if the call leads to
+  // construction it will be needed.
+  static ServiceWorkerDispatcher* ThreadSpecificInstance(
+      ThreadSafeSender* thread_safe_sender);
+
+ private:
+  // webkit_glue::WorkerTaskRunner::Observer implementation.
+  virtual void OnWorkerRunLoopStopped() OVERRIDE;
+
+  void OnServiceWorkerRegistered(int32 thread_id,
+                                 int32 request_id,
+                                 int64 service_worker_id);
+  void OnServiceWorkerUnregistered(int32 thread_id,
+                                   int32 request_id);
+
+  IDMap<WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks,
+        IDMapOwnPointer> pending_callbacks_;
+
+  scoped_refptr<ThreadSafeSender> thread_safe_sender_;
+
+  DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDispatcher);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_H_