Flush out initial [un]registerServiceWorker roundtrip

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
+#include <string>
+
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "content/child/appcache/appcache_dispatcher.h"
 #include "content/child/plugin_messages.h"
 #include "content/child/quota_dispatcher.h"
 #include "content/child/request_extra_data.h"
+#include "content/child/service_worker/web_service_worker_provider_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/common/socket_stream_handle_data.h"
 #include "content/common/swapped_out_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/public/renderer/document_state.h"
 #include "content/public/renderer/navigation_state.h"
@@ skipping 29 matching lines @@
 #endif
 
 using WebKit::WebDataSource;
 using WebKit::WebDocument;
 using WebKit::WebFrame;
 using WebKit::WebNavigationPolicy;
 using WebKit::WebPluginParams;
 using WebKit::WebReferrerPolicy;
 using WebKit::WebSearchableFormData;
 using WebKit::WebSecurityOrigin;
+using WebKit::WebServiceWorkerProvider;
 using WebKit::WebStorageQuotaCallbacks;
 using WebKit::WebString;
 using WebKit::WebURL;
 using WebKit::WebURLError;
 using WebKit::WebURLRequest;
 using WebKit::WebURLResponse;
 using WebKit::WebUserGestureIndicator;
 using WebKit::WebVector;
 using WebKit::WebView;
 using base::Time;
@@ skipping 140 matching lines @@
     return NULL;
   return new RendererWebApplicationCacheHostImpl(
       RenderViewImpl::FromWebView(frame->view()), client,
       RenderThreadImpl::current()->appcache_dispatcher()->backend_proxy());
 }
 
 WebKit::WebCookieJar* RenderFrameImpl::cookieJar(WebKit::WebFrame* frame) {
   return render_view_->cookieJar(frame);
 }
 
+WebKit::WebServiceWorkerProvider* RenderFrameImpl::createServiceWorkerProvider(
+    WebKit::WebFrame* frame,
+    WebKit::WebServiceWorkerProviderClient* client) {
+  return new WebServiceWorkerProviderImpl(
+      ChildThread::current()->thread_safe_sender(),
+      ChildThread::current()->service_worker_message_filter(),
+      GURL(frame->document().securityOrigin().toString()),

[michaeln, 2013/10/08 23:08:38]

i think this will fail for some securityOrigin strings, we have some helper
functions for this... i'll come back with a ptr to them

[alecflett, 2013/10/09 01:23:47]

So I was following a pattern I found elsewhere (again, using Quota as
inspiration) - happy to use the right pattern if this isn't it.

[kinuko, 2013/10/09 02:23:12]

Not sure michael is talking about the same thing, but common pattern is to check
if securityOrigin.isUnique() is true or not and then get toString() for its URL
only if it's true.  toString() returns non-url-like string (e.g. "null") for
unique origins.  If we're going to have a method like allowServiceWorker() (in
blink) I assume we'll do such check there (in conjunction with other necessary
checks like against permissionClient etc) so we should be safe here (quota does
this check in blink side).

+      client);
+}
+
 void RenderFrameImpl::didAccessInitialDocument(WebKit::WebFrame* frame) {
   render_view_->didAccessInitialDocument(frame);
 }
 
 WebKit::WebFrame* RenderFrameImpl::createChildFrame(
     WebKit::WebFrame* parent,
     const WebKit::WebString& name) {
   RenderFrameImpl* child_render_frame = this;
   long long child_frame_identifier = WebFrame::generateEmbedderIdentifier();
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSitePerProcess)) {
@@ skipping 679 matching lines @@
 
 void RenderFrameImpl::didLoseWebGLContext(WebKit::WebFrame* frame,
                                           int arb_robustness_status_code) {
   render_view_->Send(new ViewHostMsg_DidLose3DContext(
       GURL(frame->top()->document().securityOrigin().toString()),
       THREE_D_API_TYPE_WEBGL,
       arb_robustness_status_code));
 }
 
 }  // namespace content