Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 25008006: Flush out initial [un]registerServiceWorker roundtrip (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix request_id leak Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_H_
6 #define CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_H_
7
8 #include "base/id_map.h"
9 #include "base/memory/ref_counted.h"
10 #include "base/strings/string16.h"
11 #include "third_party/WebKit/public/platform/WebServiceWorkerProvider.h"
12 #include "webkit/child/worker_task_runner.h"
13
14 class GURL;
15
16 namespace WebKit {
17 class WebURL;
18 }
19
20 namespace IPC {
21 class Message;
22 }
23
24 namespace content {
25 class ThreadSafeSender;
26 class ServiceWorkerMessageFilter;
27 class WebServiceWorkerImpl;
28
29 class ServiceWorkerDispatcher : public webkit_glue::WorkerTaskRunner::Observer {
30 public:
31 ServiceWorkerDispatcher(ThreadSafeSender* thread_safe_sender);
32 virtual ~ServiceWorkerDispatcher();
33
34 // webkit_glue::WorkerTaskRunner::Observer implementation.
35 virtual void OnWorkerRunLoopStopped() OVERRIDE;
michaeln 2013/10/08 23:08:38 nit: could this method be private
alecflett 2013/10/09 01:23:47 Done.
36
37 void OnMessageReceived(const IPC::Message& msg);
38 bool Send(IPC::Message* msg);
39
40 void RegisterServiceWorker(
41 const WebKit::WebURL& origin,
42 const string16& pattern,
43 const GURL& script_url,
44 WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks* callbacks);
45 void UnregisterServiceWorker(
46 const WebKit::WebURL& origin,
47 const string16& pattern,
48 WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks* callbacks);
49
50 // |thread_safe_sender| needs to be passed in because if the call leads to
51 // construction it will be needed.
52 static ServiceWorkerDispatcher* ThreadSpecificInstance(
53 ThreadSafeSender* thread_safe_sender);
54
55 private:
56 void OnServiceWorkerRegistered(int32 thread_id,
57 int32 request_id,
michaeln 2013/10/08 23:08:38 here its called request_id... that's the name i li
alecflett 2013/10/09 01:23:47 Sorry I'll try to make these a little more consist
58 int32 worker_id);
michaeln 2013/10/08 23:08:38 maybe expand this to service_worker_id so its less
alecflett 2013/10/09 01:23:47 Done.
59 void OnServiceWorkerUnregistered(int32 thread_id,
60 int32 request_id,
61 int32 worker_id);
62
63 IDMap<WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks,
64 IDMapOwnPointer> pending_callbacks_;
65
66 scoped_refptr<ThreadSafeSender> thread_safe_sender_;
67
68 DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDispatcher);
69 };
70
71 } // namespace content
72
73 #endif // CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698