Flush out initial [un]registerServiceWorker roundtrip

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
+#include <string>
+
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "content/child/appcache/appcache_dispatcher.h"
 #include "content/child/quota_dispatcher.h"
 #include "content/child/request_extra_data.h"
 #include "content/common/socket_stream_handle_data.h"
 #include "content/common/swapped_out_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_constants.h"
@@ skipping 189 matching lines @@
     return NULL;
   return new RendererWebApplicationCacheHostImpl(
       RenderViewImpl::FromWebView(frame->view()), client,
       RenderThreadImpl::current()->appcache_dispatcher()->backend_proxy());
 }
 
 WebKit::WebCookieJar* RenderFrameImpl::cookieJar(WebKit::WebFrame* frame) {
   return render_view_->cookieJar(frame);
 }
 
+WebKit::WebServiceWorkerRegistry* RenderFrameImpl::serviceWorkerRegistry(
+    WebKit::WebFrame* frame) {
+  // am I supposed to be using render_view_ here or
+  // RenderViewImpl::FromWebView(frame->view()) ?

[michaeln, 2013/09/30 23:41:27]

I'd vote to make the WebServiceWorkerRegistry registry NOT frame specific and to
just have the a single instance of that thing. Would that simplify things?

Platform::serviceWorkerRegistry() sort of accessor.

[alecflett, 2013/10/01 00:17:04]

I went this way after some consultation with abarth@. I'm not a fan of the
single instance - I don't think it would simplify things as we'd have to keep
our own map and looking up the current origin to find an object that would
otherwise already be attached to the frame or view. 

I would personally like the notion of being per-origin but that concept doesn't
really exist in the WebKit API...  (though maybe it should) I'm expecting to use
the frame as a way to get to the current security origin... I feel like this is
analogous to the ApplicationCacheHost and related classes.

+  return render_view_->serviceWorkerRegistry(frame);
+}
+
 void RenderFrameImpl::didAccessInitialDocument(WebKit::WebFrame* frame) {
   render_view_->didAccessInitialDocument(frame);
 }
 
 void RenderFrameImpl::didCreateFrame(WebKit::WebFrame* parent,
                                      WebKit::WebFrame* child) {
   render_view_->Send(new ViewHostMsg_FrameAttached(
       render_view_->GetRoutingID(), parent->identifier(), child->identifier(),
       UTF16ToUTF8(child->assignedName())));
 }
@@ skipping 634 matching lines @@
 
 void RenderFrameImpl::didLoseWebGLContext(WebKit::WebFrame* frame,
                                           int arb_robustness_status_code) {
   render_view_->Send(new ViewHostMsg_DidLose3DContext(
       GURL(frame->top()->document().securityOrigin().toString()),
       THREE_D_API_TYPE_WEBGL,
       arb_robustness_status_code));
 }
 
 }  // namespace content