Flush out initial [un]registerServiceWorker roundtrip

content/child/service_worker/web_service_worker_proxy.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROXY_H_
+#define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROXY_H_
+
+#include "base/compiler_specific.h"
+#include "third_party/WebKit/public/platform/WebServiceWorker.h"
+#include "third_party/WebKit/public/web/WebFrame.h"
+
+namespace content {
+
+class WebServiceWorkerImpl

[michaeln, 2013/09/30 23:41:27]

The name of the class vs the name of the file is confusing.

[alecflett, 2013/10/01 00:17:04]

I agree but I'm running out of names for things that mean "the implementation of
the proxy for a service worker" :)

I welcome other names, but this one at least seemed consistent with the
equivalent Web* objects in the Blink API.

[kinuko, 2013/10/01 07:48:11]

Doesn't just a webserviceworker_impl.{cc,h} work?

+    : NON_EXPORTED_BASE(public WebKit::WebServiceWorker) {
+ public:
+  WebServiceWorkerImpl(int32 worker_id, bool registered)
+      : worker_id_(worker_id), registered_(registered) {}
+  virtual ~WebServiceWorkerImpl();
+

[kinuko, 2013/09/30 12:41:17]

Not directly related to this CL, but if you guys have a brief plan about what
methods this class will be exposing can you share them? (If not yet it's totally
fine too)

[alecflett, 2013/10/01 00:17:04]

This needs to be flushed out on github, here's where it will show up:

https://github.com/slightlyoff/ServiceWorker/blob/master/service_worker.ts#L71

(If the lines move, it's the class/interface that starts with 'interface
SharedServiceWorker extends Worker')

[kinuko, 2013/10/01 07:48:11]

Thanks!

+ private:
+  int32 worker_id_ ALLOW_UNUSED;
+  bool registered_ ALLOW_UNUSED;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROXY_H_