Flush out initial [un]registerServiceWorker roundtrip

content/browser/service_worker/service_worker_dispatcher_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_dispatcher_host.h"
 
+#include "base/logging.h"
 #include "content/browser/service_worker/service_worker_context.h"
 #include "content/common/service_worker_messages.h"
 #include "ipc/ipc_message_macros.h"
 #include "url/gurl.h"
 
 namespace content {
 
 ServiceWorkerDispatcherHost::ServiceWorkerDispatcherHost(
     ServiceWorkerContext* context)
     : context_(context) {}
 
 ServiceWorkerDispatcherHost::~ServiceWorkerDispatcherHost() {}
 
 bool ServiceWorkerDispatcherHost::OnMessageReceived(const IPC::Message& message,
                                                     bool* message_was_ok) {
-
   if (IPC_MESSAGE_CLASS(message) != ServiceWorkerMsgStart)
     return false;
 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP_EX(
     ServiceWorkerDispatcherHost, message, *message_was_ok)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_RegisterServiceWorker,
                         OnRegisterServiceWorker)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_UnregisterServiceWorker,
                         OnUnregisterServiceWorker)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
-void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(int32 registry_id,
-                                                       const string16& scope,
-                                                       const GURL& script_url) {
+// total hack, do not check in
+static int32 worker_id = 0;

[kinuko, 2013/09/30 12:41:17]

So the plan is we're replacing this with browser-side registry context (maybe
attached to the browser context?), which maps pattern/script to a worker_id (and
some more contextual info), and also will manage some browser-side cache/storage
stuff... am I following?

[alecflett, 2013/10/01 00:17:04]

Yes exactly.

I think either we need a global singleton (ServiceWorkerService?) or maybe just
one-per-storage-partition, which is ServiceWorkerContext. 

+
+void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
+    int32 request_id,
+    const string16& scope,
+    const GURL& script_url) {
   // TODO(alecflett): Enforce that script_url must have the same
   // origin as the registering document.
+  LOG(ERROR) << "in browser: OnRegisterServiceWorker!";
+  Send(new ServiceWorkerMsg_ServiceWorkerRegistered(request_id, worker_id++));
 }
 
 void ServiceWorkerDispatcherHost::OnUnregisterServiceWorker(
-    int32 registry_id,
-    const string16& scope) {}
+    int32 request_id,
+    const string16& scope) {
+  LOG(ERROR) << "in browser: OnUnregisterServiceWorker!";
+  Send(new ServiceWorkerMsg_ServiceWorkerUnregistered(request_id, worker_id++));
+}
 
 }  // namespace content