Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2500773002: [GeometryInterface] clean up idl. (Closed)

Created:
4 years, 1 month ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] clean up idl. remove comment which is already done item. BUG=388780 Committed: https://crrev.com/75eb89086acc6e0cfd3909418c87168eb34da776 Cr-Commit-Position: refs/heads/master@{#432787}

Patch Set 1 #

Patch Set 2 : [GeometryInterface] clean up idl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Hwanseung Lee
@dominicc, zino PTAL, thank you.
4 years, 1 month ago (2016-11-13 08:54:53 UTC) #2
zino
On 2016/11/13 08:54:53, Hwanseung Lee wrote: > @dominicc, zino > PTAL, thank you. lgtm
4 years, 1 month ago (2016-11-13 15:04:40 UTC) #4
Hwanseung Lee
@dominicc PTAL, thank you.
4 years, 1 month ago (2016-11-15 00:44:57 UTC) #5
dominicc (has gone to gerrit)
lgtm
4 years, 1 month ago (2016-11-17 03:10:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500773002/20001
4 years, 1 month ago (2016-11-17 03:16:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/316740)
4 years, 1 month ago (2016-11-17 05:25:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500773002/20001
4 years, 1 month ago (2016-11-17 05:50:17 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 06:45:28 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:47:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75eb89086acc6e0cfd3909418c87168eb34da776
Cr-Commit-Position: refs/heads/master@{#432787}

Powered by Google App Engine
This is Rietveld 408576698