Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2500763002: Remove Deque<>::findIf<>(). (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
Reviewers:
haraken, Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Deque<>::findIf<>(). This function template is unused, and any future uses are better served by using <algorithm>'s std::find_if(). R= BUG= Committed: https://crrev.com/5c396eba99f5ebb882f26a6589f9f196d65c9f3d Cr-Commit-Position: refs/heads/master@{#431855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/Source/wtf/Deque.h View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sof
please take a look.
4 years, 1 month ago (2016-11-13 07:45:46 UTC) #4
haraken
LGTM
4 years, 1 month ago (2016-11-13 21:35:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500763002/1
4 years, 1 month ago (2016-11-14 08:08:53 UTC) #9
Yuta Kitamura
lgtm
4 years, 1 month ago (2016-11-14 08:13:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 10:53:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 10:56:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c396eba99f5ebb882f26a6589f9f196d65c9f3d
Cr-Commit-Position: refs/heads/master@{#431855}

Powered by Google App Engine
This is Rietveld 408576698