chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc - Issue 25007002: Add GTK support for global Extension Commands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

Issue 25007002: Add GTK support for global Extension Commands (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revise. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

diff --git a/chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

index ccb02561afeac1e141559ed15d34d2f2ba7b729d..ba9c65ced2afa7375f6db93a46534908d405726d 100644

--- a/chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

+++ b/chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

@@ -64,6 +64,7 @@ void ExtensionKeybindingRegistryGtk::AddExtensionKeybinding(

command_service->GetNamedCommands(

extension->id(),

extensions::CommandService::ACTIVE_ONLY,

+ extensions::CommandService::REGULAR,

&commands);

for (extensions::CommandMap::const_iterator iter = commands.begin();

@@ -149,6 +150,11 @@ void ExtensionKeybindingRegistryGtk::RemoveExtensionKeybinding(

EventTargets::iterator old = iter++;

event_targets_.erase(old);

+ // If a specific command_name was requested, it has now been deleted so

+ // no further work is required.

+ if (!command_name.empty())

+ break;

}