Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2500693002: Replace unique_ptr.reset with std::move in /net (Closed)

Created:
4 years, 1 month ago by Yoonjae
Modified:
4 years, 1 month ago
Reviewers:
gavinp, Yoonjae
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset with std::move in /net BUG=644626 Committed: https://crrev.com/30473619a8be423458f6c827df099ba6cb91f330 Cr-Commit-Position: refs/heads/master@{#433499}

Patch Set 1 #

Patch Set 2 : Replace unique_ptr.reset with std::move in /net #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/http/http_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_framer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack/hpack_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
Yoonjae
@gavinp PTAL.
4 years, 1 month ago (2016-11-12 05:58:23 UTC) #2
gavinp
lgtm, thanks
4 years, 1 month ago (2016-11-14 15:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500693002/1
4 years, 1 month ago (2016-11-14 15:57:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/295759)
4 years, 1 month ago (2016-11-14 16:28:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500693002/40001
4 years, 1 month ago (2016-11-21 09:39:11 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 09:43:06 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 09:45:03 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30473619a8be423458f6c827df099ba6cb91f330
Cr-Commit-Position: refs/heads/master@{#433499}

Powered by Google App Engine
This is Rietveld 408576698