Chromium Code Reviews Chromium Code Reviews
Issue 2500653002:
MD Settings: Add import data dialog. (Closed)
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> | |
| 2 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> | |
| 3 <link rel="import" href="chrome://resources/html/polymer.html"> | |
| 4 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> | |
| 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> | |
| 7 <link rel="import" href="/md_select_css.html"> | |
| 8 <link rel="import" href="/people_page/import_data_browser_proxy.html"> | |
| 9 | |
| 10 <dom-module id="settings-import-data-dialog"> | |
| 11 <style> | |
| 12 paper-checkbox { | |
| 13 display: block; | |
| 14 margin-bottom: 20px; | |
| 15 } | |
|
tommycli
2016/11/14 18:15:57
Seems odd that we would need to define a custom st
dpapad
2016/11/14 20:35:22
Tried using list-frame, list-item. The problem is
tommycli
2016/11/14 20:45:34
Hmm.. if the only problem is the 24px left padding
dpapad
2016/11/14 21:47:57
I'll leave as-is for now, and will make sure that
| |
| 16 | |
| 17 #description { | |
| 18 align-items: center; | |
| 19 display: flex; | |
| 20 height: 40px; | |
|
Dan Beam
2016/11/15 01:27:46
can we use a var() here for the height (and prefer
dpapad
2016/11/15 01:33:46
Done.
| |
| 21 } | |
| 22 </style> | |
| 23 <template> | |
| 24 <style include="settings-shared md-select"></style> | |
| 25 <dialog is="cr-dialog" id="dialog"> | |
| 26 <div class="title">$i18n{importTitle}</div> | |
| 27 <div class="body"> | |
| 28 <span class="md-select-wrapper"> | |
| 29 <select class="md-select" on-change="onChange_"> | |
| 30 <template is="dom-repeat" items="[[browserProfiles_]]"> | |
| 31 <option value="[[item.index]]">[[item.name]]</option> | |
| 32 </template> | |
| 33 </select> | |
| 34 <span class="md-select-underline"></span> | |
| 35 </span> | |
| 36 <div id="description">$i18n{importDescription}</div> | |
| 37 <div> | |
| 38 <paper-checkbox hidden="[[!selected_.history]]"> | |
|
Dan Beam
2016/11/14 19:07:20
aren't they persistently stored as prefs somewhere
Dan Beam
2016/11/14 19:07:50
isn't this list persistently stored*
dpapad
2016/11/14 20:35:22
I don't think there are any prefs related to this
tommycli
2016/11/14 20:45:34
The Old Options code does seem to indicate some in
dpapad
2016/11/14 21:47:57
Double checked with old Options, and the checkboxe
Dan Beam
2016/11/14 22:05:45
yeah, all the pref magic in options is done in JS
| |
| 39 $i18n{importHistory} | |
| 40 </paper-checkbox> | |
| 41 <paper-checkbox hidden="[[!selected_.favorites]]"> | |
| 42 $i18n{importFavorites} | |
| 43 </paper-checkbox> | |
| 44 <paper-checkbox hidden="[[!selected_.passwords]]"> | |
| 45 $i18n{importPasswords} | |
| 46 </paper-checkbox> | |
| 47 <paper-checkbox hidden="[[!selected_.search]]"> | |
| 48 $i18n{importSearch} | |
| 49 </paper-checkbox> | |
| 50 <paper-checkbox hidden="[[!selected_.autofillFormData]]"> | |
| 51 $i18n{importAutofillFormData} | |
| 52 </paper-checkbox> | |
| 53 </div> | |
| 54 </div> | |
| 55 <div class="button-container"> | |
| 56 <div class="action-buttons"> | |
| 57 <paper-button class="cancel-button" id="cancel" on-tap="onCancelTap_"> | |
| 58 $i18n{cancel} | |
| 59 </paper-button> | |
| 60 <paper-button id="actionButton" class="action-button" | |
| 61 on-tap="onActionButtonTap_"> | |
| 62 [[getActionButtonText_(selected_)]] | |
| 63 </paper-button> | |
| 64 </div> | |
| 65 </div> | |
| 66 </dialog> | |
| 67 </template> | |
| 68 <script src="import_data_dialog.js"></script> | |
| 69 </dom-module> | |
| OLD | NEW |
