Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/nacl/renderer/nexe_load_manager.cc

Issue 250063003: Pepper: Move IME workaround from the trusted plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/renderer/pepper_plugin_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/nexe_load_manager.cc
diff --git a/components/nacl/renderer/nexe_load_manager.cc b/components/nacl/renderer/nexe_load_manager.cc
index 942aea02da90b06faa8938926a4acb84d8f9b75c..439ddc371cecf6d7c515aa74ab8544a9d4e5175c 100644
--- a/components/nacl/renderer/nexe_load_manager.cc
+++ b/components/nacl/renderer/nexe_load_manager.cc
@@ -548,6 +548,17 @@ void NexeLoadManager::set_exit_status(int exit_status) {
void NexeLoadManager::InitializePlugin() {
init_time_ = base::Time::Now();
+
+#if defined(OS_MACOSX)
+ // TODO(kochi): For crbug.com/102808, this is a stopgap solution for Lion
+ // until we expose IME API to .nexe. This disables any IME interference
+ // against key inputs, so you cannot use off-the-spot IME input for NaCl
+ // apps.
+ // This makes discrepancy among platforms and therefore we should remove
+ // this hack when IME API is made available.
+ // The default for non-Mac platforms is still off-the-spot IME mode.
+ plugin_instance_->SetTextInputType(ui::TEXT_INPUT_TYPE_NONE);
dmichael (off chromium) 2014/04/24 15:49:44 +kochi: Is this comment and code still valid? The
+#endif // defined(OS_MACOSX)
}
void NexeLoadManager::ReportStartupOverhead() const {
« no previous file with comments | « no previous file | content/public/renderer/pepper_plugin_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698