Issue 250063003: Pepper: Move IME workaround from the trusted plugin.

Issue 250063003: Pepper: Move IME workaround from the trusted plugin. (Closed)

Created:
6 years, 8 months ago by teravest

Modified:
6 years, 8 months ago

Reviewers:
dmichael (off chromium), jam, kochi

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Move IME workaround from the trusted plugin. This moves a MACOSX-specific IME workaround outside the trusted plugin as part of the effort to refactor all that code to components/nacl. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266050

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : fix compile error #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -44 lines)			Patch
M	components/nacl/renderer/nexe_load_manager.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	content/public/renderer/pepper_plugin_instance.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/fake_pepper_plugin_instance.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/pepper/fake_pepper_plugin_instance.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View	1	3 chunks	+6 lines, -41 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

You need to add an implementation for the new pure virtual in at least one ...

6 years, 8 months ago (2014-04-24 15:49:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/250063003/40001

6 years, 8 months ago (2014-04-24 21:48:42 UTC) #6

kochi

6 years, 8 months ago (2014-04-25 04:55:11 UTC) #8

Message was sent while issue was closed.

Thanks for looping me in.

I almost forgot what it was, but it looks that the workaround
is no longer necessary as Flash (the primary user) seems to use
SetTextInputType() properly.

I'll make sure locally so not only Flash but other NaCl apps
won't break and remove the #ifdef part.

Expand Messages | Collapse Messages