Add ViewObserver to View for view updates

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 30 matching lines @@
 #include "ui/gfx/interpolated_transform.h"
 #include "ui/gfx/path.h"
 #include "ui/gfx/scoped_canvas.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/gfx/transform.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/accessibility/native_view_accessibility.h"
 #include "ui/views/background.h"
 #include "ui/views/border.h"
 #include "ui/views/context_menu_controller.h"
+#include "ui/views/devtools_observer.h"
 #include "ui/views/drag_controller.h"
 #include "ui/views/focus/view_storage.h"
 #include "ui/views/layout/layout_manager.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/native_widget_private.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/tooltip_manager.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_WIN)
@@ skipping 50 matching lines @@
       snap_layer_to_pixel_boundary_(false),
       flip_canvas_on_paint_for_rtl_ui_(false),
       paint_to_layer_(false),
       accelerator_focus_manager_(NULL),
       registered_accelerator_count_(0),
       next_focusable_view_(NULL),
       previous_focusable_view_(NULL),
       focus_behavior_(FocusBehavior::NEVER),
       context_menu_controller_(NULL),
       drag_controller_(NULL),
-      native_view_accessibility_(NULL) {
+      native_view_accessibility_(NULL),
+      devtools_observer_(NULL) {

[sadrul, 2016/11/15 17:21:49]

nullptr

[Sarmad Hashmi, 2016/11/15 17:54:56]

Done.

   SetTargetHandler(this);
 }
 
 View::~View() {
   if (parent_)
     parent_->RemoveChildView(this);
 
   ViewStorage::GetInstance()->ViewRemoved(this);
 
   for (Views::const_iterator i(children_.begin()); i != children_.end(); ++i) {
@@ skipping 104 matching lines @@
   children_.erase(i);
 
   // Unlink the view first
   View* next_focusable = view->next_focusable_view_;
   View* prev_focusable = view->previous_focusable_view_;
   if (prev_focusable)
     prev_focusable->next_focusable_view_ = next_focusable;
   if (next_focusable)
     next_focusable->previous_focusable_view_ = prev_focusable;
 
+  if (devtools_observer_)
+    devtools_observer_->OnChildViewReordered(view, index);
+
   // Add it in the specified index now.
   InitFocusSiblings(view, index);
   children_.insert(children_.begin() + index, view);
 
   ReorderLayers();
 }
 
 void View::RemoveChildView(View* view) {
   DoRemoveChildView(view, true, true, false, NULL);
 }
@@ skipping 32 matching lines @@
     return;
   }
 
   if (visible_) {
     // Paint where the view is currently.
     SchedulePaintBoundsChanged(
         bounds_.size() == bounds.size() ? SCHEDULE_PAINT_SIZE_SAME :
         SCHEDULE_PAINT_SIZE_CHANGED);
   }
 
+  if (devtools_observer_)
+    devtools_observer_->OnViewBoundsChanged(this, bounds);
+
   gfx::Rect prev = bounds_;
   bounds_ = bounds;
   BoundsChanged(prev);
 }
 
 void View::SetSize(const gfx::Size& size) {
   SetBounds(x(), y(), size.width(), size.height());
 }
 
 void View::SetPosition(const gfx::Point& position) {
@@ skipping 121 matching lines @@
 }
 
 bool View::IsDrawn() const {
   return visible_ && parent_ ? parent_->IsDrawn() : false;
 }
 
 void View::SetEnabled(bool enabled) {
   if (enabled != enabled_) {
     enabled_ = enabled;
     AdvanceFocusIfNecessary();
+    if (devtools_observer_)
+      devtools_observer_->OnViewEnabledChanged(this, enabled);
     OnEnabledChanged();
   }
 }
 
 void View::OnEnabledChanged() {
   SchedulePaint();
 }
 
 // Transformations -------------------------------------------------------------
 
@@ skipping 908 matching lines @@
 int View::GetPageScrollIncrement(ScrollView* scroll_view,
                                  bool is_horizontal, bool is_positive) {
   return 0;
 }
 
 int View::GetLineScrollIncrement(ScrollView* scroll_view,
                                  bool is_horizontal, bool is_positive) {
   return 0;
 }
 
+// DevTools Observer ---------------------------------------------------------
+
+void View::SetDevToolsObserver(DevToolsObserver* devtools_observer) {
+  devtools_observer_ = devtools_observer;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // View, protected:
 
 // Size and disposition --------------------------------------------------------
 
 void View::OnBoundsChanged(const gfx::Rect& previous_bounds) {
 }
 
 void View::PreferredSizeChanged() {
   InvalidateLayout();
@@ skipping 494 matching lines @@
       // If you get this registration, you are part of a subtree that has been
       // added to the view hierarchy.
       if (GetFocusManager())
         RegisterPendingAccelerators();
     } else {
       if (details.child == this)
         UnregisterAccelerators(true);
     }
   }
 
+  if (devtools_observer_)
+    devtools_observer_->OnViewHierarchyChanged(this, details);

[sadrul, 2016/11/15 17:21:49]

Is this the right place for this? Should this be in one of  the
Propagate*Notifications functions instead?

[Sarmad Hashmi, 2016/11/15 17:54:56]

ViewHierarchyChangedImpl is called from the Propogate*Notifications functions,
so not sure if it would make a difference?

   ViewHierarchyChanged(details);
   details.parent->needs_layout_ = true;
 }
 
 void View::PropagateNativeThemeChanged(const ui::NativeTheme* theme) {
   for (int i = 0, count = child_count(); i < count; ++i)
     child_at(i)->PropagateNativeThemeChanged(theme);
   OnNativeThemeChanged(theme);
 }
 
 // Size and disposition --------------------------------------------------------
 
 void View::PropagateVisibilityNotifications(View* start, bool is_visible) {
   for (int i = 0, count = child_count(); i < count; ++i)
     child_at(i)->PropagateVisibilityNotifications(start, is_visible);
   VisibilityChangedImpl(start, is_visible);
 }
 
 void View::VisibilityChangedImpl(View* starting_from, bool is_visible) {
+  if (devtools_observer_)
+    devtools_observer_->OnViewVisibilityChanged(starting_from, is_visible);
   VisibilityChanged(starting_from, is_visible);
 }
 
 void View::BoundsChanged(const gfx::Rect& previous_bounds) {
   if (visible_) {
     // Paint the new bounds.
     SchedulePaintBoundsChanged(
         bounds_.size() == previous_bounds.size() ? SCHEDULE_PAINT_SIZE_SAME :
         SCHEDULE_PAINT_SIZE_CHANGED);
   }
@@ skipping 505 matching lines @@
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views