Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2500573003: Some easy linked_ptr removal from extensions/common/ (Closed)

Created:
4 years, 1 month ago by lazyboy
Modified:
4 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jshin+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some easy linked_ptr removal from extensions/common/ BUG=556939 Test=None, internal change. Committed: https://crrev.com/d5a387ce8c4d17179d64e958c61c9eb00addccf0 Cr-Commit-Position: refs/heads/master@{#432063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -60 lines) Patch
M extensions/common/event_filter.h View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/event_filter.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/extension_l10n_util.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M extensions/common/extension_l10n_util_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M extensions/common/message_bundle.h View 2 chunks +3 lines, -4 lines 0 comments Download
M extensions/common/message_bundle.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/message_bundle_unittest.cc View 8 chunks +25 lines, -33 lines 0 comments Download
M extensions/common/url_pattern_set.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
lazyboy
4 years, 1 month ago (2016-11-14 22:31:51 UTC) #6
asargent_no_longer_on_chrome
lgtm
4 years, 1 month ago (2016-11-15 00:41:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500573003/1
4 years, 1 month ago (2016-11-15 01:00:08 UTC) #9
commit-bot: I haz the power
Failed to apply patch for extensions/common/event_filter.cc: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-15 02:34:40 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5a387ce8c4d17179d64e958c61c9eb00addccf0 Cr-Commit-Position: refs/heads/master@{#432063}
4 years, 1 month ago (2016-11-15 03:01:49 UTC) #13
limasdf
@lazy, awesome. I can't wait to see how you gonna treat linked_ptr in e/b/api/declarative/rules_registry.h :)
4 years, 1 month ago (2016-11-15 10:45:56 UTC) #15
lazyboy
4 years, 1 month ago (2016-11-15 21:12:30 UTC) #16
Message was sent while issue was closed.
On 2016/11/15 10:45:56, limasdf wrote:
> @lazy, awesome. I can't wait to see how you gonna treat linked_ptr in
> e/b/api/declarative/rules_registry.h :)

I think we'd need to use scoped_refptr for api::events::Rule, wdyt?
(If that's what you were wondering about).

Powered by Google App Engine
This is Rietveld 408576698