Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2500543002: Add following tests : (Closed)

Created:
4 years, 1 month ago by siva
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add following tests : - enable the service protocol web server when it is already enabled - disable the service protocol web server when it is already disabled - disable the service protocol web server when it is enabled - validate field in the ServiceProviderInfo object - try connecting to the web server without the auth token when use of an auth token is enabled - try connecting to the web server with the auth token when use of an auth token is enabled - try connecting to the web server without the auth token when use of an auth token is not enabled BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b2f3bb6711208346245cd334f54d4472dd443ad0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -11 lines) Patch
A + runtime/observatory/tests/service/auth_token1_test.dart View 3 chunks +16 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/auth_token_test.dart View 2 chunks +22 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/developer_server_control_test.dart View 1 chunk +55 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 1 month ago (2016-11-11 17:06:38 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-11 18:03:37 UTC) #3
siva
4 years, 1 month ago (2016-11-11 20:42:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2f3bb6711208346245cd334f54d4472dd443ad0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698