Cache display items from SVGImage contents.

Cache display items from SVGImage contents.

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bb1c8b9d3e4acb60fb489f878963e2ccbb936b61
Cr-Commit-Position: refs/heads/master@{#431695}

[chrishtr, 2016-11-11 19:18:56]

Description was changed from

==========
none


none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-11 19:19:46]

Description was changed from

==========
none


none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Cache display items from SVGImage contents.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-11 19:24:50]

Description was changed from

==========
Cache display items from SVGImage contents.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Cache display items from SVGImage contents.

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-11 19:26:08]

Description was changed from

==========
Cache display items from SVGImage contents.

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Cache display items from SVGImage contents. It should also work for SVGImage
patterns, which 

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-11 20:56:27]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2016-11-11 22:22:40]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 22:23:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-11-11 22:41:08]

On 2016/11/11 at 20:56:28, chrishtr wrote:
> 

LGTM, this is great. Just confirming, you saw this increased perf on a concrete
page?

I wonder what this does to animometer/motionmark which has a benchmark with svg
images. No need to run it now, but may be useful to lookup the progression after
it lands (https://chromeperf.appspot.com/group_report?rev=[your revision here]).

Nit: your description has an incomplete sentence in the first line. Lets just
remove the bit about patterns.

[chrishtr, 2016-11-11 22:53:13]

Description was changed from

==========
Cache display items from SVGImage contents. It should also work for SVGImage
patterns, which 

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Cache display items from SVGImage contents.

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-11 22:54:32]

On 2016/11/11 at 22:41:08, pdr wrote:
> On 2016/11/11 at 20:56:28, chrishtr wrote:
> > 
> 
> LGTM, this is great. Just confirming, you saw this increased perf on a
concrete page?

Yes, the one from this bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=656320

~20% or so reduction in paint time, as it there are multiple SVG images on this
page.

> 
> I wonder what this does to animometer/motionmark which has a benchmark with
svg images. No need to run it now, but may be useful to lookup the progression
after it lands (https://chromeperf.appspot.com/group_report?rev=[your revision
here]).

I'll look at that once it lands.

> 
> Nit: your description has an incomplete sentence in the first line. Lets just
remove the bit about patterns.

Done.

[chrishtr, 2016-11-11 22:54:39]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-11-11 22:54:41]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:55:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:21:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-12 00:23:45]

Description was changed from

==========
Cache display items from SVGImage contents.

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Cache display items from SVGImage contents.

It works as follows:
1. SkPictureBuilder now allows an existing PaintController to be passed in the
constructor.
2. SVGImage stores a local PaintController for painting image contents.
3. When painting frames that do not invalidate the SVGImage contents, the
PaintController for the image will have the cached DisplayItems from it, and
subsequence caching will allow the LayoutView of the Page belonging to the
SVGImage to be reused.
4. If any invalidation happens on the SVGImage, the usual
caching behavior of SVG will result in the PaintController for the SVG noticing
and not caching DisplayItems or subsequences as appropriate. (*)

(*) this is easy now, because of the changes made earlier this year to use
global
invalidation cache epochs rather than PaintController-specific ones.

BUG=663953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bb1c8b9d3e4acb60fb489f878963e2ccbb936b61
Cr-Commit-Position: refs/heads/master@{#431695}
==========

[commit-bot: I haz the power, 2016-11-12 00:23:46]

Patchset 3 (id:??) landed as
https://crrev.com/bb1c8b9d3e4acb60fb489f878963e2ccbb936b61
Cr-Commit-Position: refs/heads/master@{#431695}