Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/resources/settings/site_settings/protocol_handlers.html

Issue 2500513003: Make setting's protocol handler use cr-action-menu instead of paper-item. (Closed)
Patch Set: fix return type of boolean function Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/protocol_handlers.html
diff --git a/chrome/browser/resources/settings/site_settings/protocol_handlers.html b/chrome/browser/resources/settings/site_settings/protocol_handlers.html
index ab78ee849ffd445172499102b21594cc8b55584d..265b2f10738058840550b87d8636d7a5af763662 100644
--- a/chrome/browser/resources/settings/site_settings/protocol_handlers.html
+++ b/chrome/browser/resources/settings/site_settings/protocol_handlers.html
@@ -1,10 +1,9 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper-menu-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/paper-toggle-button.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
+
<link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
<link rel="import" href="/i18n_setup.html">
<link rel="import" href="/settings_shared_css.html">
@@ -42,35 +41,33 @@
<div class="favicon-image" style$="[[computeSiteIcon(item.host)]]">
</div>
<div class="middle" >
- <div>[[item.host]]</div>
- <div class="secondary"
+ <div class="protocol-host">[[item.host]]</div>
+ <div class="secondary protocol-default"
hidden$="[[!isDefault_(index, protocol.default_handler)]]">
$i18n{handlerIsDefault}
</div>
</div>
- <paper-menu-button>
- <paper-icon-button icon="cr:more-vert"
- class="dropdown-trigger">
- </paper-icon-button>
- <paper-menu id="actionMenu" class="dropdown-content" actionable
- on-iron-activate="onActionMenuIronActivate_"
- attr-for-selected="menu-value">
- <paper-item menu-value$="[[menuActions_.SET_DEFAULT]]"
- hidden$="[[isDefault_(index, protocol.default_handler)]]"
- actionable>
- $i18n{handlerSetDefault}
- </paper-item>
- <paper-item menu-value$="[[menuActions_.REMOVE]]" actionable>
- $i18n{handlerRemove}
- </paper-item>
- </paper-menu>
- </paper-menu-button>
+ <paper-icon-button icon="cr:more-vert" on-tap="showMenu_"
+ class="dropdown-trigger">
+ </paper-icon-button>
</div>
</template>
</div>
</template>
+
+ <dialog is="cr-action-menu">
+ <button class="dropdown-item" role="option" on-tap="onDefaultTap_"
+ hidden$="[[isModelDefault_(actionMenuModel_)]]"
+ id="defaultButton">
+ $i18n{handlerSetDefault}
+ </button>
+ <button class="dropdown-item" role="option" on-tap="onRemoveTap_"
+ id="removeButton">
+ $i18n{handlerRemove}
+ </button>
+ </dialog>
</template>
<script src="protocol_handlers.js"></script>
</dom-module>

Powered by Google App Engine
This is Rietveld 408576698