Make setting's protocol handler use cr-action-menu instead of paper-item.

chrome/browser/resources/settings/site_settings/protocol_handlers.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'protocol-handlers' is the polymer element for showing the
  * protocol handlers category under Site Settings.
  */
 
@@ skipping 33 matching lines @@
      */
     categoryEnabled: Boolean,
 
     /**
      * Array of protocols and their handlers.
      * @type {!Array<!ProtocolEntry>}
      */
     protocols: Array,
 
     /**
-     * The possible menu actions.
-     * @type {MenuActions}
+     * The targetted object for menu operations.
+     * @private {?Object}
      */
-    menuActions_: {
-      type: Object,
-      value: MenuActions,
-      readOnly: true,
-    },
+    actionMenuModel_: Object
   },
 
   ready: function() {
     this.addWebUIListener('setHandlersEnabled',
         this.setHandlersEnabled_.bind(this));
     this.addWebUIListener('setProtocolHandlers',
         this.setProtocolHandlers_.bind(this));
     this.addWebUIListener('setIgnoredProtocolHandlers',
         this.setIgnoredProtocolHandlers_.bind(this));
     this.browserProxy.initializeProtocolHandlerList();
@@ skipping 54 matching lines @@
 
   /**
    * A handler when the toggle is flipped.
    * @private
    */
   onToggleChange_: function(event) {
     this.browserProxy.setProtocolHandlerDefault(this.categoryEnabled);
   },
 
   /**
-   * A handler when an action is selected in the action menu.
-   * @param {!{model: !{item: ProtocolHandlerEntry},
-   *           detail: !{selected: string}}} event
+   * The handler for when "Set Default" is selected in the action menu.
    * @private
    */
-  onActionMenuIronActivate_: function(event) {
-    var protocol = event.model.item.protocol;
-    var url = event.model.item.spec;
-    if (event.detail.selected == MenuActions.SET_DEFAULT) {
-      this.browserProxy.setProtocolDefault(protocol, url);
-    } else if (event.detail.selected == MenuActions.REMOVE) {
-      this.browserProxy.removeProtocolHandler(protocol, url);
-    }
+  onDefaultTap_: function() {
+    var item = this.actionMenuModel_.item;
+
+    this.$$('dialog[is=cr-action-menu]').close();
+    this.actionMenuModel_ = null;
+    this.browserProxy.setProtocolDefault(item.protocol, item.spec);
   },
+
+  /**
+   * The handler for when "Remove" is selected in the action menu.
+   * @private
+   */
+  onRemoveTap_: function() {
+    var item = this.actionMenuModel_.item;
+
+    this.$$('dialog[is=cr-action-menu]').close();
+    this.actionMenuModel_ = null;
+    this.browserProxy.removeProtocolHandler(item.protocol, item.spec);
+  },
+
+  /**
+   * Checks whether or not the selected actionMenuModel is the default handler
+   * for its protocol.
+   * @return {boolean} if actionMenuModel_ is default handler of its protocol.
+   */
+   isModelDefault_: function(model) {

[dpapad, 2016/11/14 21:54:09]

Do you need to declare the parameter here? Why not

isModelDefault_: function() {
  return this.actionMenuModel_.index ==
this.actionMenuModel_.protocol.default_handler;
},

There are plenty examples in the codebase, where in HTML we pass "deps" to a
binding, but in JS we simply grab the "dep" from |this| instead of using the
provided parameter.

[scottchen, 2016/11/14 22:06:01]

Ah, this is the remnant of my attempt to merge the two isDefault methods. Fixed
now.

+    return model && (model.index == model.protocol.default_handler);

[dpapad, 2016/11/14 21:54:09]

Indentation off by 1.

[scottchen, 2016/11/14 22:06:14]

Done.

+   },
+
+  /**
+   * A handler to show the action menu next to the clicked menu button.
+   * @param {!{model: !{protocol: HandlerEntry, item: ProtocolEntry,
+   *     index: number}}} event
+   * @private
+   */
+  showMenu_: function(event) {
+    this.actionMenuModel_ = event.model;
+    /** @type {!CrActionMenuElement} */ (
+        this.$$('dialog[is=cr-action-menu]')).showAt(
+            /** @type {!Element} */ (
+                Polymer.dom(/** @type {!Event} */ (event)).localTarget));
+  }
 });