Make setting's protocol handler use cr-action-menu instead of paper-item.

chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * An example empty pref.
  * @type {SiteSettingsPref}
  */
 var prefsEmpty = {
   defaults: {
@@ skipping 36 matching lines @@
  * @constructor
  * @implements {settings.SiteSettingsPrefsBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 var TestSiteSettingsPrefsBrowserProxy = function() {
   settings.TestBrowserProxy.call(this, [
     'fetchUsbDevices',
     'fetchZoomLevels',
     'getDefaultValueForContentType',
     'getExceptionList',
+    'initializeProtocolHandlerList',
+    'removeProtocolHandler',
     'removeUsbDevice',
     'removeZoomLevel',
     'resetCategoryPermissionForOrigin',
     'setCategoryPermissionForOrigin',
     'setDefaultValueForContentType',
+    'setProtocolDefault'
   ]);
 
   /** @private {!SiteSettingsPref} */
   this.prefs_ = prefsEmpty;
 
   /** @private {!Array<ZoomLevelEntry>} */
   this.zoomList_ = [];
 
   /** @private {!Array<UsbDeviceEntry>} */
   this.usbDevices_ = [];
+
+  /** @private {!Array<ProtocolEntry>} */

[dpapad, 2016/11/14 18:26:21]

If those arrays do not hold null values, annotation should be !ProtocolEntry and
!UsbDeviceEntry few lines above.

[scottchen, 2016/11/14 21:38:37]

Done.

+  this.protocolHandlers_ = [];
 };
 
 TestSiteSettingsPrefsBrowserProxy.prototype = {
   __proto__: settings.TestBrowserProxy.prototype,
 
   /**
    * Sets the prefs to use when testing.
    * @param {!SiteSettingsPref} prefs The prefs to set.
    */
   setPrefs: function(prefs) {
@@ skipping 18 matching lines @@
 
   /**
    * Sets the prefs to use when testing.
    * @param {!Array<UsbDeviceEntry>} list The usb device entry list to set.
    */
   setUsbDevices: function(list) {
     // Shallow copy of the passed-in array so mutation won't impact the source
     this.usbDevices_ = list.slice();
   },
 
+  /**
+   * Sets the prefs to use when testing.
+   * @param {!Array<ProtocolEntry>} list The protocol handlers list to set.
+   */
+  setProtocolHandlers: function(list) {
+    // Shallow copy of the passed-in array so mutation won't impact the source
+    this.protocolHandlers_ = list.slice();
+  },
+
   /** @override */
   setDefaultValueForContentType: function(contentType, defaultValue) {
     this.methodCalled(
         'setDefaultValueForContentType', [contentType, defaultValue]);
   },
 
   /** @override */
   getDefaultValueForContentType: function(contentType) {
     this.methodCalled('getDefaultValueForContentType', contentType);
 
@@ skipping 108 matching lines @@
 
   /** @override */
   fetchUsbDevices: function() {
     this.methodCalled('fetchUsbDevices');
     return Promise.resolve(this.usbDevices_);
   },
 
   /** @override */
   removeUsbDevice: function() {
     this.methodCalled('removeUsbDevice', arguments);
+  },
+
+  /** @override */
+  initializeProtocolHandlerList: function() {
+    cr.webUIListenerCallback('setHandlersEnabled', true);
+    cr.webUIListenerCallback('setProtocolHandlers', this.protocolHandlers_);
+    this.methodCalled('initializeProtocolHandlerList');
+    return Promise.resolve();

[dpapad, 2016/11/14 18:26:21]

The prod version of initializeProtocolHandlerList does not seem to return a
Promise.

[scottchen, 2016/11/14 21:38:37]

Done.

+  },
+
+  /** @override */
+  setProtocolDefault: function() {
+    this.methodCalled('setProtocolDefault', arguments);
+  },
+
+  /** @override */
+  removeProtocolHandler: function() {
+    this.methodCalled('removeProtocolHandler', arguments);
   }
 };