Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2500503002: Redirecting old ui to new ui (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
nodir, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Redirecting old ui to new ui Since we are redirecting, I've removed the login requirements from the old task/bot pages. This deletes old ui templates and tests. BUG= Committed: https://github.com/luci/luci-py/commit/3e0549ea533027b5f871e58c8cd5542f83d39bd9

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove post handlers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2243 lines) Patch
M appengine/swarming/handlers_frontend.py View 1 2 chunks +18 lines, -551 lines 0 comments Download
M appengine/swarming/handlers_test.py View 3 chunks +8 lines, -224 lines 0 comments Download
D appengine/swarming/templates/bot_view.html View 1 chunk +0 lines, -60 lines 0 comments Download
D appengine/swarming/templates/restricted_bot.html View 1 chunk +0 lines, -227 lines 0 comments Download
D appengine/swarming/templates/restricted_botslist.html View 1 chunk +0 lines, -186 lines 0 comments Download
D appengine/swarming/templates/user_task.html View 1 chunk +0 lines, -621 lines 0 comments Download
D appengine/swarming/templates/user_tasks.html View 1 chunk +0 lines, -374 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjlubick
Live at https://chromium-swarm-dev.appspot.com/
4 years, 1 month ago (2016-11-11 14:55:51 UTC) #2
M-A Ruel
https://codereview.chromium.org/2500503002/diff/1/appengine/swarming/handlers_frontend.py File appengine/swarming/handlers_frontend.py (right): https://codereview.chromium.org/2500503002/diff/1/appengine/swarming/handlers_frontend.py#newcode212 appengine/swarming/handlers_frontend.py:212: class BotDeleteHandler(auth.AuthenticatingHandler): All POST handlers are not needed anymore, ...
4 years, 1 month ago (2016-11-11 16:19:18 UTC) #4
kjlubick
Removed post handlers.
4 years, 1 month ago (2016-11-11 16:24:16 UTC) #5
M-A Ruel
lgtm
4 years, 1 month ago (2016-11-11 16:29:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500503002/20001
4 years, 1 month ago (2016-11-11 16:31:38 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 16:35:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/3e0549ea533027b5f871e58c8cd5542f83d39bd9

Powered by Google App Engine
This is Rietveld 408576698