Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2500493004: [ash-md] Fixes clipping of controls in system tray (Closed)

Created:
4 years, 1 month ago by varkha
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, Evan Stade
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixes clipping of controls in system tray BUG=664244 TEST=manual - add more VPN rows, connect one, scroll up to make sure the "Disconnect" button is stacked below the main header row. TEST=manual - Scroll Wi-Fi detailed page up so that the toggle is half-way below the header row. Press mouse, verify that the ripple is clipped byt the header row. Committed: https://crrev.com/eb7063bbe11432014548bddea36ce68fe2b36dd5 Cr-Commit-Position: refs/heads/master@{#431708}

Patch Set 1 #

Patch Set 2 : [ash-md] Fixes clipping of controls in system tray (with background) #

Patch Set 3 : [ash-md] Fixes clipping of controls in system tray (docs) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ash/common/system/tray/tray_details_view.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
varkha
tdanderson@, this is estade@'s code, just trying to land it. PTAL.
4 years, 1 month ago (2016-11-11 23:08:15 UTC) #3
Evan Stade
lgtm, perhaps with a noted added to the code about why it's necessary
4 years, 1 month ago (2016-11-11 23:09:02 UTC) #5
tdanderson
On 2016/11/11 23:09:02, Evan Stade wrote: > lgtm, perhaps with a noted added to the ...
4 years, 1 month ago (2016-11-11 23:10:17 UTC) #7
varkha
Thanks, done.
4 years, 1 month ago (2016-11-11 23:15:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500493004/60001
4 years, 1 month ago (2016-11-11 23:15:58 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-12 00:33:47 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 00:36:25 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb7063bbe11432014548bddea36ce68fe2b36dd5
Cr-Commit-Position: refs/heads/master@{#431708}

Powered by Google App Engine
This is Rietveld 408576698