Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

Issue 2500493003: [DevTools] make breakpoints better (Closed)
Patch Set: fixed context menu items for gutter Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
index 00d3811de0fb60f6365de8e695bf6340d680b4f9..7921cda8d9e36644b9ed94ec6f71ba0375c891a9 100644
--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
@@ -165,38 +165,6 @@ SourceFrame.SourcesTextEditor = class extends TextEditor.CodeMirrorTextEditor {
}
/**
- * @param {number} lineNumber
- * @param {boolean} disabled
- * @param {boolean} conditional
- */
- addBreakpoint(lineNumber, disabled, conditional) {
lushnikov 2016/11/17 04:31:50 nice to get rid of these! thanks
- if (lineNumber < 0 || lineNumber >= this.codeMirror().lineCount())
- return;
-
- var className = 'cm-breakpoint' + (conditional ? ' cm-breakpoint-conditional' : '') +
- (disabled ? ' cm-breakpoint-disabled' : '');
- this.codeMirror().addLineClass(lineNumber, 'wrap', className);
- }
-
- /**
- * @param {number} lineNumber
- */
- removeBreakpoint(lineNumber) {
- if (lineNumber < 0 || lineNumber >= this.codeMirror().lineCount())
- return;
-
- var wrapClasses = this.codeMirror().getLineHandle(lineNumber).wrapClass;
- if (!wrapClasses)
- return;
-
- var classes = wrapClasses.split(' ');
- for (var i = 0; i < classes.length; ++i) {
- if (classes[i].startsWith('cm-breakpoint'))
- this.codeMirror().removeLineClass(lineNumber, 'wrap', classes[i]);
- }
- }
-
- /**
* @param {string} type
* @param {boolean} leftToNumbers
*/

Powered by Google App Engine
This is Rietveld 408576698