[DevTools] make breakpoints better

third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 SourceFrame.SourcesTextEditor = class extends TextEditor.CodeMirrorTextEditor {
   /**
    * @param {!SourceFrame.SourcesTextEditorDelegate} delegate
    */
@@ skipping 147 matching lines @@
    */
   highlightRange(range, cssClass) {
     cssClass = 'CodeMirror-persist-highlight ' + cssClass;
     var pos = TextEditor.CodeMirrorUtils.toPos(range);
     ++pos.end.ch;
     return this.codeMirror().markText(
         pos.start, pos.end, {className: cssClass, startStyle: cssClass + '-start', endStyle: cssClass + '-end'});
   }
 
   /**
-   * @param {number} lineNumber
-   * @param {boolean} disabled
-   * @param {boolean} conditional
-   */
-  addBreakpoint(lineNumber, disabled, conditional) {

[lushnikov, 2016/11/17 04:31:50]

nice to get rid of these! thanks

-    if (lineNumber < 0 || lineNumber >= this.codeMirror().lineCount())
-      return;
-
-    var className = 'cm-breakpoint' + (conditional ? ' cm-breakpoint-conditional' : '') +
-        (disabled ? ' cm-breakpoint-disabled' : '');
-    this.codeMirror().addLineClass(lineNumber, 'wrap', className);
-  }
-
-  /**
-   * @param {number} lineNumber
-   */
-  removeBreakpoint(lineNumber) {
-    if (lineNumber < 0 || lineNumber >= this.codeMirror().lineCount())
-      return;
-
-    var wrapClasses = this.codeMirror().getLineHandle(lineNumber).wrapClass;
-    if (!wrapClasses)
-      return;
-
-    var classes = wrapClasses.split(' ');
-    for (var i = 0; i < classes.length; ++i) {
-      if (classes[i].startsWith('cm-breakpoint'))
-        this.codeMirror().removeLineClass(lineNumber, 'wrap', classes[i]);
-    }
-  }
-
-  /**
    * @param {string} type
    * @param {boolean} leftToNumbers
    */
   installGutter(type, leftToNumbers) {
     if (this._gutters.indexOf(type) !== -1)
       return;
 
     if (leftToNumbers)
       this._gutters.unshift(type);
     else
@@ skipping 703 matching lines @@
    */
   _setHighlighter(highlighter, selectionStart) {
     var overlayMode = {token: highlighter};
     this._codeMirror.addOverlay(overlayMode);
     this._highlightDescriptor = {overlay: overlayMode, selectionStart: selectionStart};
   }
 };
 
 SourceFrame.SourcesTextEditor.LinesToScanForIndentationGuessing = 1000;
 SourceFrame.SourcesTextEditor.MaximumNumberOfWhitespacesPerSingleSpan = 16;