[DevTools] make breakpoints better

third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 233 matching lines @@
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {number} lineNumber
    * @return {!Array<!Bindings.BreakpointManager.Breakpoint>}
    */
   findBreakpoints(uiSourceCode, lineNumber) {
     var breakpoints = this._breakpointsForUISourceCode.get(uiSourceCode);
     var lineBreakpoints = breakpoints ? breakpoints.get(lineNumber) : null;
-    return lineBreakpoints ? lineBreakpoints.valuesArray()[0] : [];
+    if (!lineBreakpoints)
+      return [];
+    breakpoints = [].concat.apply([], lineBreakpoints.valuesArray());

[dgozman, 2016/11/15 23:35:13]

breakpoints = lineBreakpoints.valuesArray() ?

+    breakpoints.sort((breakpoint1, breakpoint2) => breakpoint1.columnNumber() - breakpoint2.columnNumber());
+    return breakpoints;
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {number} lineNumber
    * @param {number} columnNumber
    * @return {?Bindings.BreakpointManager.Breakpoint}
    */
   findBreakpoint(uiSourceCode, lineNumber, columnNumber) {
     var breakpoints = this._breakpointsForUISourceCode.get(uiSourceCode);
@@ skipping 76 matching lines @@
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @return {!Array.<!{breakpoint: !Bindings.BreakpointManager.Breakpoint, uiLocation: !Workspace.UILocation}>}
    */
   breakpointLocationsForUISourceCode(uiSourceCode) {
     var uiSourceCodeBreakpoints = this._breakpointsForUISourceCode.get(uiSourceCode);
     var lineNumbers = uiSourceCodeBreakpoints ? uiSourceCodeBreakpoints.keysArray() : [];
     var result = [];
-    for (var i = 0; i < lineNumbers.length; ++i) {
-      var lineBreakpoints = uiSourceCodeBreakpoints.get(lineNumbers[i]);
-      var columnNumbers = lineBreakpoints.keysArray();
-      for (var j = 0; j < columnNumbers.length; ++j) {
-        var columnBreakpoints = lineBreakpoints.get(columnNumbers[j]);
-        var lineNumber = parseInt(lineNumbers[i], 10);
-        var columnNumber = parseInt(columnNumbers[j], 10);
-        for (var k = 0; k < columnBreakpoints.length; ++k) {
-          var breakpoint = columnBreakpoints[k];
-          var uiLocation = uiSourceCode.uiLocation(lineNumber, columnNumber);
-          result.push({breakpoint: breakpoint, uiLocation: uiLocation});
-        }
+    for (var lineNumber of lineNumbers)
+      result = result.concat(this.breakpontLocationsForLineNumber(uiSourceCode, lineNumber));
+    return result;
+  }
+
+  /**
+   * @param {!Workspace.UISourceCode} uiSourceCode
+   * @param {number} lineNumber
+   * @return {!Array<!{breakpoint: !Bindings.BreakpointManager.Breakpoint, uiLocation: !Workspace.UILocation}>}
+   */
+  breakpontLocationsForLineNumber(uiSourceCode, lineNumber) {

[lushnikov, 2016/11/17 04:31:50]

typo: breakpointLocationsForLineNumber

+    var uiSourceCodeBreakpoints = this._breakpointsForUISourceCode.get(uiSourceCode);
+    if (!uiSourceCodeBreakpoints)
+      return [];
+    var lineBreakpoints = uiSourceCodeBreakpoints.get(lineNumber);
+    if (!lineBreakpoints)
+      return [];
+    var result = [];
+    for (var columnNumber of lineBreakpoints.keysArray()) {
+      var columnBreakpoints = lineBreakpoints.get(columnNumber);
+      for (var breakpoint of columnBreakpoints) {
+        var uiLocation = uiSourceCode.uiLocation(lineNumber, columnNumber);
+        result.push({breakpoint: breakpoint, uiLocation: uiLocation});
       }
     }
     return result;
   }
 
   /**
    * @return {!Array.<!{breakpoint: !Bindings.BreakpointManager.Breakpoint, uiLocation: !Workspace.UILocation}>}
    */
   allBreakpointLocations() {
     var result = [];
@@ skipping 720 matching lines @@
     this.sourceFileId = breakpoint._sourceFileId;
     this.lineNumber = breakpoint.lineNumber();
     this.columnNumber = breakpoint.columnNumber();
     this.condition = breakpoint.condition();
     this.enabled = breakpoint.enabled();
   }
 };
 
 /** @type {!Bindings.BreakpointManager} */
 Bindings.breakpointManager;