Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2500483002: Revert of Turn on hermetic toolchain for all corp machines. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on hermetic toolchain for all corp machines. (patchset #3 id:40001 of https://codereview.chromium.org/2445993004/ ) Reason for revert: Breaks compilation in WebRTC since we use the same toolchain (but needs 10.12 SDK which is not available in the hermetic toolchain). See https://bugs.chromium.org/p/webrtc/issues/detail?id=6700#c1 Original issue's description: > Turn on hermetic toolchain for all corp machines. > > BUG=659726 > > Committed: https://crrev.com/7778e931dabc1fa85d0b77321e3fdef166e0b6a0 > Committed: https://crrev.com/da01626aa3c2e1533c53c325de9bd579f0aa54d2 > Cr-Original-Commit-Position: refs/heads/master@{#430376} > Cr-Commit-Position: refs/heads/master@{#430863} TBR=thakis@chromium.org,dpranke@chromium.org,brettw@chromium.org,justincohen@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -75 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
D build/mac/should_use_hermetic_xcode.py View 1 chunk +0 lines, -26 lines 0 comments Download
M build/mac_toolchain.py View 3 chunks +25 lines, -39 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_chromium
Created Revert of Turn on hermetic toolchain for all corp machines.
4 years, 1 month ago (2016-11-11 14:07:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500483002/1
4 years, 1 month ago (2016-11-11 14:07:40 UTC) #3
kjellander_chromium
4 years, 1 month ago (2016-11-11 14:23:45 UTC) #5
I think I found a better way to work around this for downstream projects:
https://codereview.chromium.org/2494103002/ so I unchecked the CQ bit for now.
Let me know what you think about that instead.

I have confirmed that it solves the problem WebRTC was seeing at least.

Powered by Google App Engine
This is Rietveld 408576698