Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2500453002: Fix a bug in printing of string literals with escape sequences. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
Reviewers:
ahe
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a bug in printing of string literals with escape sequences. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/kernel/commit/323030a4cf43859c68725d3d59cdf58a3d0e2c16

Patch Set 1 #

Patch Set 2 : Add testcase #

Total comments: 2

Patch Set 3 : Add copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M lib/text/ast_to_text.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A testcases/input/stringliteral.dart View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A testcases/spec-mode/stringliteral.baseline.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
A testcases/strong-mode/stringliteral.baseline.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A testcases/type-propagation/stringliteral.baseline.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
4 years, 1 month ago (2016-11-11 10:15:36 UTC) #2
ahe
lgtm https://codereview.chromium.org/2500453002/diff/20001/testcases/input/stringliteral.dart File testcases/input/stringliteral.dart (right): https://codereview.chromium.org/2500453002/diff/20001/testcases/input/stringliteral.dart#newcode1 testcases/input/stringliteral.dart:1: var color = 'brown'; No copyright.
4 years, 1 month ago (2016-11-11 10:53:07 UTC) #3
asgerf
https://codereview.chromium.org/2500453002/diff/20001/testcases/input/stringliteral.dart File testcases/input/stringliteral.dart (right): https://codereview.chromium.org/2500453002/diff/20001/testcases/input/stringliteral.dart#newcode1 testcases/input/stringliteral.dart:1: var color = 'brown'; On 2016/11/11 10:53:07, ahe wrote: ...
4 years, 1 month ago (2016-11-11 11:00:15 UTC) #4
asgerf
4 years, 1 month ago (2016-11-11 11:22:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
323030a4cf43859c68725d3d59cdf58a3d0e2c16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698