Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2500433002: Revert of Correct spacing in scroll contents of Ash MD detailed view. (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, fukino
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Correct spacing in scroll contents of Ash MD detailed view. (patchset #1 id:1 of https://codereview.chromium.org/2484913006/ ) Reason for revert: Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/59826 according to keywords "system" "tray" "views" in the description. Original issue's description: > Correct spacing in scroll contents of Ash MD detailed view. > > This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto > ensure that there is a correct padding between top row and scroll contents. > This also removes spacing between children in ScrollContentsView to comply with > the latest MD design spec. > > BUG=632102, 663199, 663457, 663461, 663154, 632025, 632115 > TEST=manually verified the layout. > > Committed: https://crrev.com/bb150edfa1495353882b799b39e05b0d181bcd9c > Cr-Commit-Position: refs/heads/master@{#431480} TBR=tdanderson@chromium.org,fukino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632102, 663199, 663457, 663461, 663154, 632025, 632115 Committed: https://crrev.com/1137d16544665bb926542a25c986f0750433caa3 Cr-Commit-Position: refs/heads/master@{#431517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ash/common/system/tray/tray_details_view.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hiroshige
Created Revert of Correct spacing in scroll contents of Ash MD detailed view.
4 years, 1 month ago (2016-11-11 07:30:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500433002/1
4 years, 1 month ago (2016-11-11 07:31:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 07:32:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1137d16544665bb926542a25c986f0750433caa3 Cr-Commit-Position: refs/heads/master@{#431517}
4 years, 1 month ago (2016-11-11 07:41:11 UTC) #7
hiroshige
On 2016/11/11 07:41:11, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 1 month ago (2016-11-11 11:45:55 UTC) #8
hiroshige
4 years, 1 month ago (2016-11-11 12:35:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2492833004/ by hiroshige@chromium.org.

The reason for reverting is: Not relevant to the test failure.
BUG=664428
.

Powered by Google App Engine
This is Rietveld 408576698