Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25004007: Update 'requests' lib to v2.0. (Closed)

Created:
7 years, 2 months ago by Vadim Sh.
Modified:
7 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Update 'requests' lib to v2.0. New version has a bunch of relevant fixes: * Timeouts now apply to read time if stream=False. * Chunked encoding fixes. * Better handling of streaming downloads. * Improved streaming behaviour, particularly for compressed data. It looks like Session object in new version copies cookie jar rather than holds reference to it. Thus new RequestEngine.reload_cookies method that is called whenever auth related cookies are added to original cookie jar. BUG= R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226291

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5874 lines, -4720 lines) Patch
M third_party/requests/HISTORY.rst View 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/requests/README.rst View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/requests/README.swarming View 1 chunk +3 lines, -3 lines 1 comment Download
M third_party/requests/__init__.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/requests/adapters.py View 9 chunks +45 lines, -18 lines 0 comments Download
M third_party/requests/auth.py View 4 chunks +9 lines, -6 lines 0 comments Download
M third_party/requests/compat.py View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/requests/cookies.py View 5 chunks +22 lines, -5 lines 0 comments Download
M third_party/requests/exceptions.py View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/requests/models.py View 15 chunks +81 lines, -37 lines 0 comments Download
M third_party/requests/packages/charade/__init__.py View 1 chunk +32 lines, -32 lines 0 comments Download
M third_party/requests/packages/charade/big5prober.py View 1 chunk +42 lines, -42 lines 0 comments Download
M third_party/requests/packages/charade/chardistribution.py View 1 chunk +231 lines, -231 lines 0 comments Download
M third_party/requests/packages/charade/charsetgroupprober.py View 1 chunk +106 lines, -106 lines 0 comments Download
M third_party/requests/packages/charade/codingstatemachine.py View 1 chunk +61 lines, -61 lines 0 comments Download
M third_party/requests/packages/charade/constants.py View 1 chunk +39 lines, -39 lines 0 comments Download
M third_party/requests/packages/charade/cp949prober.py View 1 chunk +44 lines, -44 lines 0 comments Download
M third_party/requests/packages/charade/escprober.py View 1 chunk +86 lines, -86 lines 0 comments Download
M third_party/requests/packages/charade/escsm.py View 1 chunk +242 lines, -242 lines 0 comments Download
M third_party/requests/packages/charade/eucjpprober.py View 1 chunk +90 lines, -90 lines 0 comments Download
M third_party/requests/packages/charade/euckrprober.py View 1 chunk +42 lines, -42 lines 0 comments Download
M third_party/requests/packages/charade/euctwprober.py View 1 chunk +41 lines, -41 lines 0 comments Download
M third_party/requests/packages/charade/gb2312prober.py View 1 chunk +41 lines, -41 lines 0 comments Download
M third_party/requests/packages/charade/hebrewprober.py View 1 chunk +283 lines, -283 lines 0 comments Download
M third_party/requests/packages/charade/jpcntx.py View 1 chunk +219 lines, -219 lines 0 comments Download
M third_party/requests/packages/charade/langbulgarianmodel.py View 1 chunk +229 lines, -229 lines 0 comments Download
M third_party/requests/packages/charade/langcyrillicmodel.py View 1 chunk +329 lines, -329 lines 0 comments Download
M third_party/requests/packages/charade/langgreekmodel.py View 1 chunk +225 lines, -225 lines 0 comments Download
M third_party/requests/packages/charade/langhebrewmodel.py View 1 chunk +201 lines, -201 lines 0 comments Download
M third_party/requests/packages/charade/langhungarianmodel.py View 1 chunk +225 lines, -225 lines 0 comments Download
M third_party/requests/packages/charade/langthaimodel.py View 1 chunk +200 lines, -200 lines 0 comments Download
M third_party/requests/packages/charade/latin1prober.py View 1 chunk +139 lines, -139 lines 0 comments Download
M third_party/requests/packages/charade/mbcharsetprober.py View 1 chunk +86 lines, -86 lines 0 comments Download
M third_party/requests/packages/charade/mbcsgroupprober.py View 1 chunk +54 lines, -54 lines 0 comments Download
M third_party/requests/packages/charade/mbcssm.py View 1 chunk +575 lines, -575 lines 0 comments Download
M third_party/requests/packages/charade/sbcharsetprober.py View 1 chunk +120 lines, -120 lines 0 comments Download
M third_party/requests/packages/charade/sbcsgroupprober.py View 1 chunk +69 lines, -69 lines 0 comments Download
M third_party/requests/packages/charade/sjisprober.py View 1 chunk +91 lines, -91 lines 0 comments Download
M third_party/requests/packages/charade/universaldetector.py View 1 chunk +172 lines, -172 lines 0 comments Download
M third_party/requests/packages/charade/utf8prober.py View 1 chunk +76 lines, -76 lines 0 comments Download
M third_party/requests/packages/urllib3/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/requests/packages/urllib3/_collections.py View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/requests/packages/urllib3/connectionpool.py View 20 chunks +218 lines, -70 lines 0 comments Download
M third_party/requests/packages/urllib3/contrib/ntlmpool.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/requests/packages/urllib3/contrib/pyopenssl.py View 5 chunks +185 lines, -8 lines 0 comments Download
M third_party/requests/packages/urllib3/exceptions.py View 2 chunks +28 lines, -2 lines 0 comments Download
A third_party/requests/packages/urllib3/fields.py View 1 chunk +177 lines, -0 lines 0 comments Download
M third_party/requests/packages/urllib3/filepost.py View 5 chunks +31 lines, -28 lines 0 comments Download
M third_party/requests/packages/urllib3/packages/ssl_match_hostname/__init__.py View 3 chunks +52 lines, -15 lines 0 comments Download
M third_party/requests/packages/urllib3/poolmanager.py View 6 chunks +94 lines, -27 lines 0 comments Download
M third_party/requests/packages/urllib3/request.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/requests/packages/urllib3/response.py View 8 chunks +67 lines, -7 lines 0 comments Download
M third_party/requests/packages/urllib3/util.py View 6 chunks +254 lines, -6 lines 0 comments Download
M third_party/requests/sessions.py View 13 chunks +74 lines, -48 lines 0 comments Download
M third_party/requests/status_codes.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/requests/structures.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/requests/utils.py View 8 chunks +49 lines, -28 lines 0 comments Download
M utils/net.py View 4 chunks +12 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Vadim Sh.
I prefer to update dependencies whenever new versions come out. I'll submit this after verifying ...
7 years, 2 months ago (2013-09-27 22:28:46 UTC) #1
M-A Ruel
On 2013/09/27 22:28:46, Vadim Sh. wrote: > I prefer to update dependencies whenever new versions ...
7 years, 2 months ago (2013-09-28 01:29:26 UTC) #2
Vadim Sh.
7 years, 2 months ago (2013-10-01 20:38:48 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r226291 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698