Issue 2500393003: Remove smoke and observe from SDK DEPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2500393003: Remove smoke and observe from SDK DEPS (Closed)

Created:
4 years, 1 month ago by kevmoo

Modified:
4 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	.packages	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	DEPS	View		4 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

Bill Hesse

LGTM. Should these remain a part of dart-lang, and thus be moved to dart.googlesource.com, or ...

4 years, 1 month ago (2016-11-15 20:36:39 UTC) #3

kevmoo

On 2016/11/15 20:36:39, Bill Hesse wrote: > LGTM. Should these remain a part of dart-lang, ...

4 years, 1 month ago (2016-11-15 20:37:52 UTC) #4

kevmoo

4 years, 1 month ago (2016-11-15 20:38:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4710e92cfc3996307cf08cf9a3a06dc78f9e1f1d (presubmit successful).