Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2500373003: Compute WorldImpact for mirror analysis. (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove Enqueuer.registerTypeUse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -54 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 1 5 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 16 chunks +46 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-15 13:51:57 UTC) #2
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-15 17:14:13 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-16 10:08:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bce19eba0402985c62a02c6589f310efab67846c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698