[Suggestions] Add a flag for the Suggestions Service.

[Suggestions] Add a flag for the Suggestions Service.

Add an entry in about flags to facilitate turning on the Suggestions service.

BUG=366263
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266086

[Mathieu, 2014-04-23 21:34:53]

Hi can you have a look?

[beaudoin, 2014-04-23 21:43:17]

LGTM with some nits.

https://codereview.chromium.org/250033004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/250033004/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1185: kOsAll,
Just making sure this is what you want, it's not meant to be mobile only?

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:377: const char kDisableSuggestionsService[] =
"disable-suggestions-service";
For consistency, align equals (or wrap if it doesn't fit).

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:647: const char kEnableSuggestionsService[] =
"enable-suggestions-service";
Same here.

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.h:115: extern const char
kDisableSuggestionsService[];
Alphabetize.

[Mathieu, 2014-04-24 13:23:11]

Thanks

https://codereview.chromium.org/250033004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/250033004/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1185: kOsAll,
On 2014/04/23 21:43:17, beaudoin wrote:
> Just making sure this is what you want, it's not meant to be mobile only?

I'll set it for Android and CrOS. On other platforms we can set it easily on the
command-line.

The flag does not enable new code for now.

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:377: const char kDisableSuggestionsService[] =
"disable-suggestions-service";
On 2014/04/23 21:43:17, beaudoin wrote:
> For consistency, align equals (or wrap if it doesn't fit).

Done.

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:647: const char kEnableSuggestionsService[] =
"enable-suggestions-service";
On 2014/04/23 21:43:17, beaudoin wrote:
> Same here. 

Done.

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/250033004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.h:115: extern const char
kDisableSuggestionsService[];
On 2014/04/23 21:43:17, beaudoin wrote:
> Alphabetize.

Done.

[Mathieu, 2014-04-24 13:27:11]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-04-24 13:44:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathp@chromium.org/250033004/40001

[commit-bot: I haz the power, 2014-04-24 15:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:00:58]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[Mathieu, 2014-04-24 15:02:52]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:03:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathp@chromium.org/250033004/40001

[commit-bot: I haz the power, 2014-04-24 16:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:16:39]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Mathieu, 2014-04-24 17:15:30]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-04-24 17:15:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathp@chromium.org/250033004/40001

[commit-bot: I haz the power, 2014-04-24 21:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 21:07:10]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Mathieu, 2014-04-24 22:11:23]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:12:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathp@chromium.org/250033004/40001

[commit-bot: I haz the power, 2014-04-25 02:24:49]

Change committed as 266086