Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2500323002: Revert of Fix a crash when AsyncTask cannot be scheduled while posting notification updates (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
Reviewers:
qinmin, gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a crash when AsyncTask cannot be scheduled while posting notification updates (patchset #2 id:20001 of https://codereview.chromium.org/2502793002/ ) Reason for revert: Caused test failures. See http://crbug.com/665257 BUG=665257 Original issue's description: > Fix a crash when AsyncTask cannot be scheduled while posting notification updates > > When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. > In that case, we should delay the updates to next update. > > BUG=664928 > > Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c > Cr-Commit-Position: refs/heads/master@{#431934} TBR=dfalcantara@chromium.org,qinmin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664928 Committed: https://crrev.com/350925bf0e87c2111322453618c95447f9781a03 Cr-Commit-Position: refs/heads/master@{#432118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -35 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 3 chunks +20 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
horo
Created Revert of Fix a crash when AsyncTask cannot be scheduled while posting notification updates
4 years, 1 month ago (2016-11-15 05:40:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500323002/1
4 years, 1 month ago (2016-11-15 05:41:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 05:42:15 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 05:45:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/350925bf0e87c2111322453618c95447f9781a03
Cr-Commit-Position: refs/heads/master@{#432118}

Powered by Google App Engine
This is Rietveld 408576698