Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported…

Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported and export code for top level fields and all JS interop types was broken. This change reduces code size of a large Angular2 app by 6%.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/27287baa576317e8684943c95d0abce4883f9e24

[Jacob, 2016-11-15 01:45:28]

jacobr@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[Jacob, 2016-11-15 01:45:28]

Only re-export the main methods.
The ddc codegen doesn't depend on any other methods being exported and
export code for top level fields and all JS interop types was broken.
This change reduces code size of a large Angular2 app by 6%.

[vsm, 2016-11-15 15:13:21]

https://codereview.chromium.org/2500283002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (left):

https://codereview.chromium.org/2500283002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:521: // top-level fields,
getters, setters need to copy the property
Any reason to delete this?  I think we hit this path with an exported main like:

var main = () {
  return () => print('hello');
}();

Though I suspect we'll lose main if it's reassigned?

[vsm, 2016-11-15 15:37:10]

https://codereview.chromium.org/2500283002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2500283002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:523: // We only need to
export main as it is the only method party of the
How about restoring the old code with just an option / default to only re-export
main?

We can later add some options here - re-export all, re-export main, re-export
annotated.

var main = exportedNames.get('main');
var exports = main == null ? <Element>[] : [ main ];
for (var export in exports) { 
  ...
}

[Jacob, 2016-11-15 16:44:13]

On 2016/11/15 15:37:10, vsm wrote:
>
https://codereview.chromium.org/2500283002/diff/1/pkg/dev_compiler/lib/src/co...
> File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):
> 
>
https://codereview.chromium.org/2500283002/diff/1/pkg/dev_compiler/lib/src/co...
> pkg/dev_compiler/lib/src/compiler/code_generator.dart:523: // We only need to
> export main as it is the only method party of the
> How about restoring the old code with just an option / default to only
re-export
> main?
> 
> We can later add some options here - re-export all, re-export main, re-export
> annotated.
> 
> var main = exportedNames.get('main');
> var exports = main == null ? <Element>[] : [ main ];
> for (var export in exports) { 
>   ...
> }

Chatted offline. Filed issue: https://github.com/dart-lang/sdk/issues/27823
and referenced it in a TODO in the code rather than adding back the broken
re-export all code.

Filed 
https://github.com/dart-lang/sdk/issues/27824
to track having the dart spec specify that main must be a method and not a
variable that happens to be a function.

[vsm, 2016-11-15 16:52:20]

lgtm

[Jacob, 2016-11-15 17:35:48]

Description was changed from

==========
Only re-export the main methods. The ddc codegen doesn't depend on any other
methods being exported and export code for top level fields and all JS interop
types was broken. This change reduces code size of a large Angular2 app by 6%.

BUG=
==========

to

==========
Only re-export the main methods. The ddc codegen doesn't depend on any other
methods being exported and export code for top level fields and all JS interop
types was broken. This change reduces code size of a large Angular2 app by 6%.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/27287baa576317e8684943c95d0abce4883f9e24
==========

[Jacob, 2016-11-15 17:35:49]

Committed patchset #3 (id:40001) manually as
27287baa576317e8684943c95d0abce4883f9e24 (presubmit successful).