Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2500273003: Presentation API: add settings for presentation.receiver being exposed. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, haraken, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, zhaobin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Presentation API: add settings for presentation.receiver being exposed. It will allow the browser process to create a renderer with the right settings, thus exposing the presentation.receiver object. BUG=647296 R=mfoltz@chromium.org Committed: https://crrev.com/57359d9170e32f1c8a67434b249d0b27d33dffbf Cr-Commit-Position: refs/heads/master@{#435066}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : update property-access-tests and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -11 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/presentation/presentation-receiver.html View 1 chunk +21 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/Presentation.cpp View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
mlamouri (slow - plz ping)
mfoltz@, PTAL +zhaobin@ CC'd FYI
4 years, 1 month ago (2016-11-15 03:12:42 UTC) #2
mark a. foltz
LGTM, looks like a rebase is required.
4 years, 1 month ago (2016-11-15 19:20:43 UTC) #6
mlamouri (slow - plz ping)
+mkwst@ for content/public/common/common_param_traits_macros.h +jochen@ for uber-OWNERS stamp :)
4 years, 1 month ago (2016-11-15 22:09:03 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-17 01:58:43 UTC) #13
Mike West
Adding the item to the IPC struct LGTM.
4 years, 1 month ago (2016-11-17 14:33:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500273003/40001
4 years, 1 month ago (2016-11-18 14:06:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/340555)
4 years, 1 month ago (2016-11-18 15:32:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500273003/60001
4 years ago (2016-11-29 19:51:49 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-29 20:12:23 UTC) #28
commit-bot: I haz the power
4 years ago (2016-11-29 20:17:43 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/57359d9170e32f1c8a67434b249d0b27d33dffbf
Cr-Commit-Position: refs/heads/master@{#435066}

Powered by Google App Engine
This is Rietveld 408576698