Remove ipc/unix_domain_socket_util.*

Remove ipc/unix_domain_socket_util.*

BUG=659448
Committed: https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362
Cr-Commit-Position: refs/heads/master@{#434089}

[Sam McNally, 2016-11-16 00:13:22]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-16 00:25:52]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-16 00:43:59]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 01:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:00:14]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-11-17 07:26:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 07:27:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:07:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-11-17 08:42:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 08:42:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-17 09:35:32]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-11-17 09:35:36]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-11-17 09:35:38]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-11-17 09:47:06]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 09:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-17 09:48:08]

Patchset #2 (id:80001) has been deleted

[Sam McNally, 2016-11-17 09:48:36]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 09:48:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-17 09:49:20]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-11-17 09:51:25]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-11-17 09:51:36]

Patchset #1 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-11-17 09:51:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-17 10:36:55]

sammc@chromium.org changed reviewers:
+ hidehiko@chromium.org, reveman@chromium.org, rockot@chromium.org,
sky@chromium.org

[Sam McNally, 2016-11-17 10:36:56]

+reveman for //components/exo

+hidehiko for //components/arc

+sky for //chrome

+rockot for //ipc and //mojo

[commit-bot: I haz the power, 2016-11-17 10:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 10:54:04]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-11-17 10:58:26]

Could you add TEST= line with what you tested?

https://codereview.chromium.org/2500263004/diff/120001/components/arc/arc_ses...
File components/arc/arc_session.cc (right):

https://codereview.chromium.org/2500263004/diff/120001/components/arc/arc_ses...
components/arc/arc_session.cc:427: if
(!mojo::edk::ServerAcceptConnection(socket_fd.get(), &scoped_fd) ||
There is a diff between ServerOnConnect and ServerAcceptConnection().

ServerAcceptConnection checks if the peer is running in the same EUID or not,
and if not, it does not set the fd non-blocking, while ServerOnConnect does not
check it.

Here, ARC is running in another user, so this looks incompatible?

[reveman, 2016-11-17 13:22:57]

components/exo lgtm

[sky, 2016-11-17 18:07:29]

LGTM

https://codereview.chromium.org/2500263004/diff/120001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/2500263004/diff/120001/chrome/common/DEPS#new...
chrome/common/DEPS:44: "service_process_util": [
I'm surprised this matches service_process_util_mac.mm. I would expect you to
need a wild card.

[Sam McNally, 2016-11-18 02:48:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:49:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-18 03:49:01]

On 2016/11/17 10:58:26, hidehiko wrote:
> Could you add TEST= line with what you tested?
> 
My understanding was that TEST= lines are for manual testing. I haven't done any
testing other than the automated tests run by the trybots. Is there something
else I should be doing to test this?

https://codereview.chromium.org/2500263004/diff/120001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/2500263004/diff/120001/chrome/common/DEPS#new...
chrome/common/DEPS:44: "service_process_util": [
On 2016/11/17 18:07:29, sky wrote:
> I'm surprised this matches service_process_util_mac.mm. I would expect you to
> need a wild card.

I guess checkdeps doesn't do a full match. Added a wild card anyway so this
doesn't rely on that.

https://codereview.chromium.org/2500263004/diff/120001/components/arc/arc_ses...
File components/arc/arc_session.cc (right):

https://codereview.chromium.org/2500263004/diff/120001/components/arc/arc_ses...
components/arc/arc_session.cc:427: if
(!mojo::edk::ServerAcceptConnection(socket_fd.get(), &scoped_fd) ||
On 2016/11/17 10:58:26, hidehiko wrote:
> There is a diff between ServerOnConnect and ServerAcceptConnection().
> 
> ServerAcceptConnection checks if the peer is running in the same EUID or not,
> and if not, it does not set the fd non-blocking, while ServerOnConnect does
not
> check it.
> 
> Here, ARC is running in another user, so this looks incompatible?

It actually drops the connection entirely, which sounds even more undesirable.
I've changed ServerAcceptConnection to make the EUID check optional and disabled
it for this call.

[commit-bot: I haz the power, 2016-11-18 04:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:11:09]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-11-18 08:30:25]

LGTM for components/arc/.
Tested ARC on test device manually, and it successfully booted.

[Sam McNally, 2016-11-22 22:47:41]

rockot: ping

[Ken Rockot(use gerrit already), 2016-11-22 22:48:41]

lgtm

[Sam McNally, 2016-11-22 22:59:29]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-22 22:59:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2500263004/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-11-22 23:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:04:41]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-11-22 23:25:22]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-22 23:25:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, rockot@chromium.org, reveman@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2500263004/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-22 23:26:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 01:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:30:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-11-23 01:35:07]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:35:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 02:34:01]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1479864907516420,
"parent_rev": "e3a6c584a9026f7e96c617bab4c93b3be7a86dd6", "commit_rev":
"36e13e2b425e43e8955d4d26be20f090b1ad8cb7"}

[commit-bot: I haz the power, 2016-11-23 02:34:29]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-11-23 02:36:00]

Description was changed from

==========
Remove ipc/unix_domain_socket_util.*

BUG=659448
==========

to

==========
Remove ipc/unix_domain_socket_util.*

BUG=659448

Committed: https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362
Cr-Commit-Position: refs/heads/master@{#434089}
==========

[commit-bot: I haz the power, 2016-11-23 02:36:02]

Patchset 3 (id:??) landed as
https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362
Cr-Commit-Position: refs/heads/master@{#434089}