[Sync] Let ModelTypeRegistry filter out initial download USS types.

[Sync] Let ModelTypeRegistry filter out initial download USS types.

BUG=658002
Committed: https://crrev.com/e776c62ce54b3d743d018585d7383ef6cc5fb1f0
Cr-Commit-Position: refs/heads/master@{#434288}

[maxbogue, 2016-11-15 00:23:00]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:24:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:43:19]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-11-15 05:27:59]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-11-15 05:27:59]

Pavel, PTAL!

[pavely, 2016-11-19 01:36:54]

https://codereview.chromium.org/2500223002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/model_type_registry.cc (right):

https://codereview.chromium.org/2500223002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_registry.cc:249: return
Intersection(GetInitialSyncEndedTypes(), GetEnabledNonBlockingTypes());
If USS type's initial_sync_done=false, and directory has data for this type
(after failed attempt at migration) then I think type will be excluded from
download. I think you need to adjust it for the value of initial_sync_done.

[maxbogue, 2016-11-22 20:25:27]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 20:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-11-22 20:28:05]

PTAL! I was concerned for a while that this would not work with the encryption
case, but I believe that types are disabled before being
re-enabled/initial-synced for encryption, are they not? In that case this is
still the correct approach. If that's not the case, then we are already risking
hitting this DCHECK in the worker:

https://cs.chromium.org/chromium/src/components/sync/engine_impl/model_type_w...

https://codereview.chromium.org/2500223002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/model_type_registry.cc (right):

https://codereview.chromium.org/2500223002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_registry.cc:249: return
Intersection(GetInitialSyncEndedTypes(), GetEnabledNonBlockingTypes());
On 2016/11/19 01:36:54, pavely wrote:
> If USS type's initial_sync_done=false, and directory has data for this type
> (after failed attempt at migration) then I think type will be excluded from
> download. I think you need to adjust it for the value of initial_sync_done.

Ah, I didn't notice the result being initialized to
directory()->InitialSyncEndedTypes() in that function. Good catch, done.

[commit-bot: I haz the power, 2016-11-22 21:14:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:14:42]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-11-23 15:12:02]

lgtm

[maxbogue, 2016-11-23 19:56:37]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:57:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:53:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479930997217550,
"parent_rev": "f33834de42c72d1b83143dfcab5fa572226ec82c", "commit_rev":
"cb988c7f41187bc5be40eaf70a8d55bb1ba11f55"}

[commit-bot: I haz the power, 2016-11-23 23:54:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 23:58:20]

Description was changed from

==========
[Sync] Let ModelTypeRegistry filter out initial download USS types.

BUG=658002
==========

to

==========
[Sync] Let ModelTypeRegistry filter out initial download USS types.

BUG=658002

Committed: https://crrev.com/e776c62ce54b3d743d018585d7383ef6cc5fb1f0
Cr-Commit-Position: refs/heads/master@{#434288}
==========

[commit-bot: I haz the power, 2016-11-23 23:58:21]

Patchset 2 (id:??) landed as
https://crrev.com/e776c62ce54b3d743d018585d7383ef6cc5fb1f0
Cr-Commit-Position: refs/heads/master@{#434288}